Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling error in FirestoreDecodingError #5520

Merged
merged 3 commits into from
May 12, 2020
Merged

Spelling error in FirestoreDecodingError #5520

merged 3 commits into from
May 12, 2020

Conversation

lorenzofiamingo
Copy link
Contributor

Just a spelling error

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lorenzofiamingo
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 3, 2020
@paulb777
Copy link
Member

paulb777 commented May 4, 2020

@lorenzofiamingo Thanks for the fix! The test failure is due to #5523 so can be ignored here.

I'll assign to the firestore team to do the merge and to work out the release plan.

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your PR!

@wilhuff wilhuff merged commit 9f17a76 into firebase:master May 12, 2020
@firebase firebase locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants