Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only fail a StorageTask once #5245

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Only fail a StorageTask once #5245

merged 3 commits into from
Apr 2, 2020

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 1, 2020

This should fix an occasional flake I was seeing in testUnauthenticatedSimpleGetDataTooSmall where the expectation was getting fulfilled twice.

@ryanwilson
Copy link
Member

LGTM, please wait for @schmidt-sebastian's review

schmidt-sebastian
schmidt-sebastian approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I wonder if this should be a "completed" state and shared between FIRStorageTaskStatusSuccess and FIRStorageTaskStatusFailure.

@schmidt-sebastian schmidt-sebastian removed their assignment Apr 1, 2020
@paulb777
Copy link
Member Author

paulb777 commented Apr 1, 2020

@schmidt-sebastian I changed it to a completed state test and also added it to the other locations in the file. PTAL

schmidt-sebastian
schmidt-sebastian approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage is receiving so much love this week! Thanks.

FirebaseStorage/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
# Unreleased
- [fixed] Fix the rare case where a StorageTask would call its completion callbacks more than
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/the/a

@paulb777 paulb777 changed the base branch from pb-swift-docs to master April 1, 2020 23:54
@paulb777 paulb777 merged commit d6f3f8d into master Apr 2, 2020
@paulb777 paulb777 deleted the pb-fail-once branch April 2, 2020 00:00
pranavrajgopal pushed a commit that referenced this pull request Apr 8, 2020
@paulb777 @pranavrajgopal
Only fail a StorageTask once (#5245)
267ae92
ryanwilson pushed a commit that referenced this pull request Apr 24, 2020
@paulb777 @ryanwilson
Only fail a StorageTask once (#5245)
23119ba
@firebase firebase locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@paulb777 paulb777

Labels
api: storage cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@paulb777 @ryanwilson @schmidt-sebastian @googlebot @google-oss-bot