Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashlytics add warning about including new and old SDK #4755

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Crashlytics add warning about including new and old SDK #4755

merged 3 commits into from
Jan 28, 2020

Conversation

samedson
Copy link
Contributor

@samedson samedson commented Jan 28, 2020 •
edited

Including multiple crash reporters tends to cause issues with registering exception handlers. Making this a warning so that we don't break builds. Putting in the public header so that zip install / Carthage users get the same warning.

Related to #4753

ryanwilson
ryanwilson approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we may want to add: something about "The Crashlytics SDK has been deprecated and FirebaseCrashlytics should be used instead."?

@samedson
Copy link
Contributor Author

@ryanwilson gonna leave that statement off for now. We're still treating the Crashlytics SDK as non-deprecated until FirebaseCrashlytics is out of beta

@samedson samedson merged commit b9e8c48 into master Jan 28, 2020
@samedson samedson deleted the crashlytics-compatibility-warning branch January 28, 2020 15:55
@samedson samedson mentioned this pull request Jan 31, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@jasonhu-g jasonhu-g Awaiting requested review from jasonhu-g

Assignees
No one assigned
Labels
api: crashlytics cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samedson @ryanwilson @googlebot @google-oss-bot