-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firebase/Analytics (GoogleAppMeasurement.framework) is using Keychain APIs incorrectly #4742
Comments
This comment has been minimized.
This comment has been minimized.
hey, I tried my best there google-bot :( |
Thanks for the report. Filed internally to the Analytics team at b/148272122. @morganchen12 Any idea what went wrong with the google-bot? |
Looks like we may have missed a deploy when I updated the template paths. Google bot should be fixed now. |
https://forums.developer.apple.com/thread/46429#135833 We should definitely do this soon, but the change is a little complicated since we need to migrate the old keychain entries over from Data to String without losing any of them. |
This issue should be fixed in the latest SDK release (6.18). |
[REQUIRED] Step 1: Describe your environment
CocoaPods
[REQUIRED] Step 2: Describe the problem
The
GoogleAppMeasurement.framework
is misusing the systemKeychain
APIs.The documentation for
kSecAttrAccount
constant says:(emphasis mine)
Firebase / GoogleAppMeasurement misuses this API and sends along value of type
CFData
/NSData
.Steps to reproduce:
NSData
object.I figured it's coming from y'alls by running:
Relevant Code:
Here's an easy way to reproduce it by just throwing this bit of Swift code into an existing application (it's pretty horrible, but for the purposes of illustration, etc)
On my machine/app it prints the following:
The text was updated successfully, but these errors were encountered: