Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always check if IID and token are consistent #4025

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Always check if IID and token are consistent #4025

merged 3 commits into from
Oct 9, 2019

Conversation

charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Oct 8, 2019 •
edited

If they don't have the same prefix, refresh the token from backend with the current IID. This helps with backward compatibility when we adopt FIS

@charlotteliang
always check inconsistency if IID and token do not have the same pref…
f8160ba 
…ix, this helps with backward compatibility when we adopt fis
@charlotteliang charlotteliang changed the title always check inconsistency if IID and token Always check if IID and token are consistent Oct 8, 2019
maksymmalyhin
maksymmalyhin approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on Travis green

@charlotteliang charlotteliang merged commit af730a9 into master Oct 9, 2019
@charlotteliang charlotteliang deleted the iid-token-format branch October 9, 2019 18:13
@firebase firebase locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@paulb777 paulb777 Awaiting requested review from paulb777

@andirayo andirayo Awaiting requested review from andirayo

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charlotteliang @maksymmalyhin @googlebot