Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firebase Pod to the repo #4021

Merged
merged 6 commits into from
Oct 8, 2019
Merged

Add Firebase Pod to the repo #4021

merged 6 commits into from
Oct 8, 2019

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Oct 8, 2019

Introduces Firebase pod support, Firebase.h and Firebase module support for tvOS and macOS.

Broken pod try functionality is removed.

Integration tests were added in #4020 and merged here.

maksymmalyhin
maksymmalyhin approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulb777 paulb777 merged commit 5895838 into master Oct 8, 2019
@paulb777 paulb777 deleted the pb-firebase-pod branch October 8, 2019 21:57
@firebase firebase locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulb777 @maksymmalyhin @googlebot