Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I hope GDTEvent can be renamed #3729

Closed
zengqingf opened this issue Aug 30, 2019 · 3 comments · Fixed by #3808
Closed

I hope GDTEvent can be renamed #3729

zengqingf opened this issue Aug 30, 2019 · 3 comments · Fixed by #3808
Assignees
@mikehaney24
Labels
GoogleDataTransport
Milestone
6.9.0

Comments

@zengqingf
Copy link

I hope GDTEvent can be renamed as it conflicts with tencent mobile advertising，
https://d3g.qq.com/gdt/sdk/ios/release/GDT_iOS_SDK_4.10.8.zip
Tencent mobile advertising is very famous in China, so I had to choose one or the other
@google-oss-bot

This comment has been minimized.

Sign in to view
@ryanwilson
Copy link
Member

@zengqingf thank you very much for bringing this to our attention! Looking into it now.

@mikehaney24
Copy link
Contributor

I'm working through a couple proposals to solve this problem

@morganchen12 morganchen12 mentioned this issue Sep 9, 2019
Closed
@mikehaney24 mikehaney24 mentioned this issue Sep 9, 2019
Merged
@paulb777 paulb777 added this to the M56 milestone Sep 9, 2019
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikehaney24 mikehaney24

Labels
GoogleDataTransport
Projects
None yet
Milestone
6.9.0
Development

Successfully merging a pull request may close this issue.

Rename GDT core libraries to GDTCOR firebase/firebase-ios-sdk
5 participants
@paulb777 @mikehaney24 @ryanwilson @zengqingf @google-oss-bot