Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release Tooling] Stop including 'Info.plist's in static xcframeworks #12243

Merged
merged 3 commits into from
Jan 5, 2024
Merged

[Release Tooling] Stop including 'Info.plist's in static xcframeworks #12243

merged 3 commits into from
Jan 5, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 5, 2024 •
edited

Static xcframeworks containing privacy manifests should be embedded in Xcode 15. The Info.plists that have been historically included in our static xcframeworks should therefore be removed.

Note, only the Info.plists within the platform frameworks (.framework) need to be removed. The root level Info.plist in the xcframework (.xcframework) does not seem to cause issues.

Testing

Locally built a FirebaseSharedSwift.xcframework with and without these changes:

diff --color <(tree FrameworkWithPlist) <(tree FrameworkWithoutPlist)
1c1
< FrameworkWithoutPlist
---
> FrameworkWithPlist
9a10
>     │       ├── Info.plist
24a26
>     │       ├── Info.plist
44a47
>     │       ├── Info.plist
64a68
>     │       ├── Info.plist
84a89
>     │       ├── Info.plist
99a105
>             ├── Info.plist
115c121
< 38 directories, 75 files
---
> 38 directories, 81 files

Additional Tasks Before Merging

  • Diff the Firebase.zip created from this PR's CI with the 10.19.0 zip.
  • Ensure that .bundles still contain an Info.plist.

@ncooke3 ncooke3 added this to the 10.20.0 - M142 milestone Jan 5, 2024
paulb777
paulb777 approved these changes Jan 5, 2024
View reviewed changes
FirebaseCore/CHANGELOG.md Outdated Show resolved Hide resolved
@ncooke3 ncooke3 requested a review from paulb777 January 5, 2024 19:07
@ncooke3 ncooke3 merged commit 0fa8498 into main Jan 5, 2024
5 checks passed
@ncooke3 ncooke3 deleted the nc/remove-plists branch January 5, 2024 19:46
Sero67
Sero67 reviewed Jan 22, 2024
View reviewed changes
Copy link

@Sero67 Sero67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slm

@firebase firebase locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sero67 Sero67 Sero67 left review comments

@andrewheard andrewheard andrewheard approved these changes

@paulb777 paulb777 Awaiting requested review from paulb777

Assignees
No one assigned
Labels
api: core release-tooling
Projects
None yet
Milestone
10.20.0 - M142
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ncooke3 @paulb777 @andrewheard @Sero67 @google-oss-bot