Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email enumeration protection related error and doc updates #12081

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Email enumeration protection related error and doc updates #12081

merged 7 commits into from
Nov 17, 2023

Conversation

renkelvin
Copy link
Contributor

  1. Add support of INVALID_LOGIN_CREDENTIALS error.
  2. Update ref docs for several apis.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited

✅  No API diff detected

Commit: 642e77f
Last updated: Wed Nov 15 12:42 PST 2023
View workflow logs & download artifacts

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Nov 9, 2023 •
edited

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 68.53% (a0fcb67) to 68.52% (642e77f) by -0.01%.

    FilenameBase (a0fcb67)Merge (642e77f)Diff
    FIRAuthBackend.m81.92%81.93%+0.02%
    FIRAuthKeychainServices.m59.66%58.80%-0.86%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dlrJepLNFy.html

renkelvin added 6 commits November 15, 2023 11:27
Error changes
703c638
Docs update
1ad0032
warnings
5575ca3
pr issues
81daeb2
Reuse FIRAuthErrorCodeInvalidCredentials
6ec29fa
Update FIRAuth.h
f3dd103 
Remove deprecated swift tests since there is no way to surpass warnings in swift

Revert "Remove deprecated swift tests since there is no way to surpass warnings in swift"

This reverts commit e49c948.

Revert "Update FIRAuth.h"

This reverts commit 358020d.

Revert "Revert "Update FIRAuth.h""

This reverts commit c800109c56d671c68d573fef9f7d694299f6a2a7.
@paulb777 paulb777 mentioned this pull request Nov 17, 2023
Closed
@renkelvin renkelvin merged commit 7605a18 into master Nov 17, 2023
67 checks passed
@renkelvin renkelvin deleted the invalid-login-cred branch November 17, 2023 22:50
paulb777
paulb777 reviewed Nov 18, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG update for the public API changes

@yqiang yqiang mentioned this pull request Dec 11, 2023
Closed
@firebase firebase locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

@ncooke3 ncooke3 ncooke3 left review comments

@prameshj prameshj prameshj approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@renkelvin @google-oss-bot @paulb777 @prameshj @ncooke3