Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xcode 15.1 build warning #12027

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix Xcode 15.1 build warning #12027

merged 1 commit into from
Oct 31, 2023

Conversation

paulb777
Copy link
Member

Fix the following:

    - WARN  | xcodebuild:  /Users/p/gh6/firebase-ios-sdk/FirebasePerformance/Sources/Gauges/CPU/FPRCPUGaugeCollector.m:48:37: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.76% (e813561) to 94.71% (d0bd36e) by -0.05%.

    FilenameBase (e813561)Merge (d0bd36e)Diff
    FPRGaugeManager.m97.39%95.42%-1.96%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/auzdespQnH.html

@paulb777 paulb777 merged commit a64205b into master Oct 31, 2023
49 checks passed
@paulb777 paulb777 deleted the pb-perf151 branch October 31, 2023 14:22
visumickey
visumickey reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@firebase firebase locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey left review comments

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulb777 @google-oss-bot @visumickey @ncooke3