Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[visionOS] Provide support for building Firestore on visionOS #11492

Merged
merged 4 commits into from
Jun 29, 2023
Merged

[visionOS] Provide support for building Firestore on visionOS #11492

merged 4 commits into from
Jun 29, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 29, 2023 •
edited

#no-changelog

@ncooke3 ncooke3 requested a review from andrewheard June 29, 2023 19:22
andrewheard
andrewheard approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Package.swift Show resolved Hide resolved
@ncooke3 ncooke3 marked this pull request as ready for review June 29, 2023 21:20
morganchen12
morganchen12 approved these changes Jun 29, 2023
View reviewed changes
Firestore/CHANGELOG.md Show resolved Hide resolved
ncooke3
ncooke3 commented Jun 29, 2023
View reviewed changes
Copy link
Member Author

@ncooke3 ncooke3 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some comments of the rational behind the versioning strategy. (Resolved them to unblock merging.)

Package.swift Show resolved Hide resolved
Package.swift Show resolved Hide resolved
Package.swift Show resolved Hide resolved
Package.swift Show resolved Hide resolved
@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (f96a7f2)Merge (0ea0009)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JmNB16JzmX.html

@ncooke3 ncooke3 merged commit aedf427 into master Jun 29, 2023
40 checks passed
@ncooke3 ncooke3 deleted the nc/spm-visionos branch June 29, 2023 22:06
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.05% (f96a7f2) to 88.05% (0ea0009) by +0.00%.

    FilenameBase (f96a7f2)Merge (0ea0009)Diff
    leveldb_key.cc98.82%99.02%+0.20%
    leveldb_remote_document_cache.cc96.41%94.61%-1.80%
    ordered_code.cc93.90%94.39%+0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FLUZerWtfb.html

peterfriese pushed a commit that referenced this pull request Jul 14, 2023
@ncooke3 @peterfriese
[visionOS] Provide support for building Firestore on visionOS (#11492)
b80bf92 
* [visionOS] Provide support for building Firestore on visionOS

* Style

* Refactor dep. functions

* Add CHANGELOG entry
@firebase firebase locked and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ncooke3 @google-oss-bot @andrewheard @morganchen12