Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload-symbols to 3.16 to support Xcode 15 #11463

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

samedson
Copy link
Contributor

@samedson samedson commented Jun 21, 2023

This should resolve some of the issues mentioned in #11400

Change 1: Support Non-embedded / No Info.plist

It's becoming more common that developers don't have an Info.plist file embedded in their .app.

To support this, upload-symbols has been updated to not read the Info.plist. Now it will get the bundle ID and platform from the build environment variables.

Change 2: Xcode 15

Xcode 15 sets the User Script Sandboxing build setting to YES by default. This settings enforces that all files read and written to in the app's build directory need to be specified in the Build Phase's Input / Output Files.

Changes to support this:

Either of these configurations should work with Xcode 15 (using Swift Package Manager):

Option 1: Using Input Files

Specify the following in your Input Files

$(BUILT_PRODUCTS_DIR)/$(UNLOCALIZED_RESOURCES_FOLDER_PATH)/GoogleService-Info.plist
$(BUILT_PRODUCTS_DIR)/$(EXECUTABLE_PATH)
${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}
${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}/Contents/Resources/DWARF/${TARGET_NAME}
Screenshot 2023-06-21 at 10 21 45 AM

Option 2: Using Input File Lists

Specify ${BUILD_DIR}/../../SourcePackages/checkouts/firebase-ios-sdk/Crashlytics/CrashlyticsInputFiles.xcfilelist as your Input File Lists

Screenshot 2023-06-21 at 10 22 57 AM

@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseCrashlytics

    TypeBase (7630c5a)Merge (be2bce5)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xqkW0pFyJN.html

@samedson samedson merged commit 1ef1ea2 into master Jun 21, 2023
33 of 34 checks passed
@samedson samedson deleted the upload-symbols-xc15 branch June 21, 2023 19:49
@bestwnh
Copy link

bestwnh commented Jun 25, 2023

@samedson Could you help to check for this issue #11471 ? Could this change make any fix for it?

mt-hodaka added a commit to mt-hodaka/ios-app-template that referenced this pull request Jul 17, 2023
@firebase firebase locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants