Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM Firestore for Catalyst. No such Module. #11119

Closed
jesus-mg-ios opened this issue Apr 13, 2023 · 10 comments
Closed

SPM Firestore for Catalyst. No such Module. #11119

jesus-mg-ios opened this issue Apr 13, 2023 · 10 comments
Assignees
@ncooke3
Labels
api: firestore Catalyst Swift Package Manager

Comments

@jesus-mg-ios
Copy link

jesus-mg-ios commented Apr 13, 2023 •
edited

Description

Hi:

I'm getting this error when I try to compile for catalyst (SPM 10.8.0). For iOS all works as expected.

image

These are the dependencies of the target that on build time throw the error:

image

In intermediates I can see a difference between the build of Catalyst and the simulator:

image

image

FirebaseFirestoreSwift.build is included on iOS simulator but not on catalyst. I don't know if it's correct or not, and the cause of it @ncooke3

Any ideas on how to solve it?

Thanks in advance

Reproducing the issue

No response

Firebase SDK Version

10.8.0

Xcode Version

14.3.0

Installation Method

Swift Package Manager

Firebase Product(s)

Firestore

Targeted Platforms

macCatalyst

Relevant Log Output

No response

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet 
Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet 
Replace this line with the contents of your Podfile.lock!
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@ncooke3
Copy link
Member

ncooke3 commented Apr 13, 2023

FirebaseFirestoreSwift.build is included on iOS simulator but not on catalyst. I don't know if it's correct or not, and the cause of it @ncooke3

Hmm, weird. I'm in the process of reproducing it now. Looking into this...

@ncooke3
Copy link
Member

ncooke3 commented Apr 13, 2023 •
edited

So I created a very basic app that supports Catalyst. I added an import FirebaseFirestore and referenced a symbol from the module. I'm able to build that on Catalyst (I'm using Xcode 14.2). So I'm not reproducing the No such module 'FirebaseFirestore'.

I am however seeing a build failure when importing FirebaseFirestoreSwift. I'm seeing No such module 'FirebaseFirestoreSwift'. On iOS, this succeeds so that seems to correspond with your observations of the differing build directories.

I'm not sure why FirebaseFirestoreSwift failed for me when your build error referenced FirebaseFirestore. None of this is expected though so continuing to look into it.

@jesus-mg-ios
Copy link
Author

jesus-mg-ios commented Apr 13, 2023 •
edited

mmmm I don't know if it could making it fail, but I can see a condition without catalyst ->

image

image

And others include it (In this case I looked at the other binary)

image

@ncooke3
Copy link
Member

ncooke3 commented Apr 13, 2023

Yep, this should explain the issue. I'm tracking down how this happened.

@ncooke3
Copy link
Member

ncooke3 commented Apr 13, 2023

In 10.8.0, the minimum Swift tools version was bumped and I needed to explicitly add catalyst to those platforms arrays. This was an oversight and can be fixed with a 10.8.1 that I'm currently working on– apologies for the inconvenience here @jesus-mg-ios.

@jesus-mg-ios
Copy link
Author

Thanks @ncooke3 for your fast response and support.

@ncooke3
Copy link
Member

ncooke3 commented Apr 13, 2023

Hi @jesus-mg-ios–– I've release 10.8.1. Could you try updating to this latest release?

@jesus-mg-ios
Copy link
Author

It works @ncooke3, thanks for your effort on it. 💯

@ncooke3
Copy link
Member

ncooke3 commented Apr 13, 2023

Thank you for reporting! 🙂

@ncooke3 ncooke3 closed this as completed Apr 13, 2023
@firebase firebase locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ncooke3 ncooke3

Labels
api: firestore Catalyst Swift Package Manager
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paulb777 @google-oss-bot @ncooke3 @jesus-mg-ios