Add limited use token to FirAppeCheck Interface #11086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalyntan
reviewed
Apr 8, 2023
weixifan
reviewed
Apr 14, 2023
ncooke3
reviewed
Apr 14, 2023
There was a problem hiding this comment.
Thanks @aiwenisevan! Leaving a first round pass review. Mainly just documentation nits.
ncooke3
reviewed
Apr 14, 2023
|
Not able to use scripts/style.sh to format AppDelegate.swift file, and thus failing the style checks. Also tried swift-format to format the file, doesn't work either. Does anyone know how I can fix this? Thanks! |
Script updated in #11097
…facNONCE Cherry picked from another commit and needs to merge
ncooke3
approved these changes
Apr 17, 2023
FirebaseAppCheck/Apps/FIRAppCheckTestApp/FIRAppCheckTestApp/AppDelegate.swift
Outdated
Show resolved
Hide resolved
|
Oh, and please add an entry for the feature in the |
rosalyntan
approved these changes
Apr 17, 2023
FirebaseAppCheck/Apps/FIRAppCheckTestApp/FIRAppCheckTestApp/AppDelegate.swift
Outdated
Show resolved
Hide resolved
FirebaseAppCheck/Apps/FIRAppCheckTestApp/FIRAppCheckTestApp/AppDelegate.swift
Show resolved
Hide resolved
rosalyntan
approved these changes
Apr 17, 2023
FirebaseAppCheck/Apps/FIRAppCheckTestApp/FIRAppCheckTestApp/AppDelegate.swift
Show resolved
Hide resolved
andrewheard
approved these changes
Apr 17, 2023
FirebaseAppCheck/Apps/FIRAppCheckTestApp/FIRAppCheckTestApp/AppDelegate.swift
Outdated
Show resolved
Hide resolved
Size Report 1Affected ProductsTest Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion:
Added LimitedUseTokenWithCompletion to FIRAppCheck interface, and added unit tests accordingly.
Added function in FIRAppCheckTestApp to test limited-use token is obtained.
Tests:
Passed all unit tests and tested with AppCheckTestApp
Api Changes:
refer to this approved api proposal