Merge App check auth integration into master branch #11056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Auth App check integration without unit testing * Add Unitest for AppCheck Auth Integration * Style the format for Auth-Appcheck Integration * Fix typo in import for FIRAppCheckInterop * Style this file * Fix wrong import * Fix style for this file * Fix style in this file * Add Source path for FIRAppCheckInterop * Add self to async block in Unit Test * Fix: pass appcheckInterop to request configuration * style the fixed files * revert files that are only for local testing * modify init method to avoid more changes * remove extra comments * upload for debug unit test * Revert Sample changes and add appcheck into unit tests * Fix issues in FIRAuthRequestConfiguration and typos in unit tests * fix error loading and revert pod files * Add spaces to keep style consistent
* pass appCheckToken as URL fragment * pass appcheck token as url fragments to phone provider * for test purpose only: commented async function * test if it is google cloud error * formatting the file * formatting the file * fix comments issues * remove printing function * remove unused property * Adding Unit test for passing appchecktoekn as a url fragment * add import for FIRAppCheckTokenResultInterop * Add separate file for FIRFakeAppCheck and Modify accordingly * add copyright comments for bewly created files * Add declaration for completion in FIRFakeAppCheck * add correct param decalaration * clean FIRFakeAppCheck.h * add method in FIRAppcheck.h to avoid complaints * correct copyright info * fix typo in FIRFakeAppCheck.m * Recover declarations * solve comments issues
|
Please rebase or merge with the master branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Testing
Note: All changes (besides resolving merge conflicts) have been previously reviewed.