Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIRMultiFactor does not support NSSecureCoding correctly #10632

Closed
igor-makarov opened this issue Jan 3, 2023 · 2 comments · Fixed by #10633
Closed

FIRMultiFactor does not support NSSecureCoding correctly #10632

igor-makarov opened this issue Jan 3, 2023 · 2 comments · Fixed by #10633
Labels
api: auth

Comments

@igor-makarov
Copy link
Contributor

Description

The FIRMultiFactor conforms to NSSecureCoding but does not support it correctly.

According to Apple:

An object that does override init(coder:) must decode any enclosed objects using the decodeObjectOfClass:forKey: method.

(NSSecureCoding documentation)

In addition, the user property is a weak reference to parent object and should be set outside encode/decode.

Reproducing the issue

No response

Firebase SDK Version

10.3.0

Xcode Version

14.1

Installation Method

CocoaPods

Firebase Product(s)

Authentication

Targeted Platforms

iOS

Relevant Log Output

No response

If using Swift Package Manager, the project's Package.resolved

No response

If using CocoaPods, the project's Podfile.lock

No response
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@igor-makarov igor-makarov mentioned this issue Jan 3, 2023
Merged
@igor-makarov
Copy link
Contributor Author

@paulb777 I've encountered this and already have a fix in #10633.

@firebase firebase locked and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix secure coding bugs in MFA igor-makarov/firebase-ios-sdk
3 participants
@igor-makarov @google-oss-bot @rizafran