Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added handling of error returned from a blocking cloud function #10628

Merged
merged 8 commits into from
Jan 5, 2023
Merged

added handling of error returned from a blocking cloud function #10628

merged 8 commits into from
Jan 5, 2023
+58 −0

Conversation

jlalvarez18
Copy link
Contributor

@jlalvarez18 jlalvarez18 commented Dec 30, 2022 •
edited

The SDK did not handle the errors returned from a cloud blocking function (auth). The message sent from the backend will now be presented in the NSError.

paulb777
paulb777 reviewed Dec 31, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We'll review with the team next week.

FirebaseAuth/Tests/Sample/AuthSample.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@paulb777
Copy link
Member

paulb777 commented Jan 1, 2023

Thanks. CI is showing this warning:

- WARN  | [OSX] xcodebuild:  /Users/runner/work/firebase-ios-sdk/firebase-ios-sdk/FirebaseAuth/Sources/Backend/FIRAuthBackend.m:1457:9: warning: nil passed to a callee that requires a non-null 1st parameter [nullability.NullPassedToNonnull]

@paulb777 paulb777 added this to the 10.4.0 - M126 milestone Jan 4, 2023
renkelvin
renkelvin suggested changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@renkelvin renkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to mention that please move new error code to L415.

@paulb777
Copy link
Member

paulb777 commented Jan 5, 2023

Thanks @jlalvarez18! Merging now, and it will release in the upcoming Firebase 10.4

@paulb777 paulb777 merged commit 0b3bf61 into firebase:master Jan 5, 2023
@firebase firebase locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

@renkelvin renkelvin renkelvin approved these changes

Assignees

@renkelvin renkelvin

Labels
api: auth
Projects
None yet
Milestone
10.4.0 - M126
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlalvarez18 @paulb777 @renkelvin