Deploying functions with failurePolicy should not always require --force #798
Comments
|
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
|
Hey @rbruggem , I believe that this is working as intended ATM. Trying to set a failurePolicy on a function that does not have one yet should trigger this warning or require --force. The idea behind this is that setting a failure policy can cause functions to be retired many times, which can be dangerous if your functions perform expensive operations or are not built to be idempotent. |
|
Closing since this is WAI. |
|
Reopening for continued discussion. The claim that this is WAI suggested that we only require --force or a confirmation when first adding a failure policy to the function. The confirmation is actually happening every time a function with a failure policy is used. Will raise with the team. |
Fixes firebase/firebase-functions#798 We can now conditionally list functions earlier in the deploy pipeline if there are any functions with a failure policy in the current set of functions to deploy. Silence the prompt if all functions with failure policies already had failure policies. Also modifies prepare.ts to avoid redndantly calling listallfunctions later.
* Only prompt for failurePolicies if they are new. Fixes firebase/firebase-functions#798 We can now conditionally list functions earlier in the deploy pipeline if there are any functions with a failure policy in the current set of functions to deploy. Silence the prompt if all functions with failure policies already had failure policies. Also modifies prepare.ts to avoid redundantly calling listallfunctions later.
* Only prompt for failurePolicies if they are new. Fixes firebase/firebase-functions#798 We can now conditionally list functions earlier in the deploy pipeline if there are any functions with a failure policy in the current set of functions to deploy. Silence the prompt if all functions with failure policies already had failure policies. Also modifies prepare.ts to avoid redundantly calling listallfunctions later.
Related issues
The comment explains how it should work.
#425 (comment)
[REQUIRED] Version info
node: 10.18.1
firebase-functions: 3.11.0
firebase-tools: 8.12.0
8.12.0firebase-admin: 8.6.0
[REQUIRED] Test case
firebase deploy --only functions:THEFUNCTIONerrors with:Error: Pass the --force option to deploy functions with a failure policy[REQUIRED] Steps to reproduce
Add
failurePolicy: { retry: {} }to an existing function which does not have a failure policy set.[REQUIRED] Expected behavior
Running
firebase deploy --only functions:THEFUNCTIONwould deploy the function successfully without the use of--force.[REQUIRED] Actual behavior
Error: Pass the --force option to deploy functions with a failure policyWere you able to successfully deploy your functions?
Only with
--forcewhich is not ideal to have in a CICD pipeline.The text was updated successfully, but these errors were encountered: