Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance][UIBlocking] AppStateMonitor Collect Activity Frame Data Prob #2672

Closed
ethanhua opened this issue May 18, 2021 · 5 comments
Closed

[Performance][UIBlocking] AppStateMonitor Collect Activity Frame Data Prob #2672

ethanhua opened this issue May 18, 2021 · 5 comments
Assignees
@visumickey @jeremyjiang-dev
Labels
api: performance needs-attention

Comments

@ethanhua
Copy link

截屏2021-05-18 下午3 02 31

FirebasePerformance Log show that our slowFrame&frozenFrame data for each page is added on top of the data for all previous pages，maybe need to call FrameMetricsAggregator.reset method at activity stop lifecycle to solve this problems

截屏2021-05-18 下午3 06 39

Every time the FrameMetricsAggregator.remove method is called, it returns the same mMetrics instance that was not cleared at the stop time, resulting in all pages using the same data

截屏2021-05-18 下午3 09 33
@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@ethanhua ethanhua changed the title [Performance][UIBlocking] AppStateMonitor Collect Activity Frame Data have Probs [Performance][UIBlocking] AppStateMonitor Collect Activity Frame Data Probs May 18, 2021
@ethanhua ethanhua changed the title [Performance][UIBlocking] AppStateMonitor Collect Activity Frame Data Probs [Performance][UIBlocking] AppStateMonitor Collect Activity Frame Data Prob May 18, 2021
@aguatno
Copy link

aguatno commented May 19, 2021

Hi @ethanhua thanks for reporting. May we know what version of the SDK version you are using? Also, would you be able to create a project in GitHub that I could clone to reproduce? I'd like to make sure I'm using the same setup as your environment.

@ethanhua
Copy link
Author

@aguatno hello, my project sdk version:
截屏2021-05-21 上午10 57 27
截屏2021-05-21 上午10 57 52

i check the logic in source code of firebase perf module, this probs may exist in lasted version

@yalunqin yalunqin assigned yalunqin and jeremyjiang-dev and unassigned yalunqin May 24, 2021
@yalunqin
Copy link

Thank you ethanhua, just FYI we are actively investigating this issue now. We will keep you posted.

@jeremyjiang-dev jeremyjiang-dev mentioned this issue Jun 15, 2021
Merged
@jeremyjiang-dev
Copy link
Contributor

PR #2736 is submitted to fix this issue.
@ethanhua Thank you for reporting the issue and suggesting the fixes!

@firebase firebase locked and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@visumickey visumickey

@jeremyjiang-dev jeremyjiang-dev

Labels
api: performance needs-attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@visumickey @ethanhua @google-oss-bot @aguatno @yalunqin @jeremyjiang-dev