Tangentially (or maybe not), editors should have access to <figure> and <figcaption> in wikitext per my comment in T25932#7070297.

In T318433#8256434, @Izno wrote:

Tangentially (or maybe not), editors should have access to <figure> and <figcaption> in wikitext per my comment in T25932#7070297.

That's a separate debate, one on which I think there is a wide gap in consensus.

I think it's reasonable to ensure that the CSS rules have "class based" equivalents to the figure styling, eg figure[typeof=...], .enwiki-figure { ... }. I don't think I agree that that means we need to emit redundant class definitions in Parsoid HTML.

I think "a huge inline comment explaining why" (as mentioned in the task description) is sufficient, to wit: some template authors want their templates to be styled in the same way as mediawiki figures, and this allows them to do so. That seems straightforward enough.

In T318433#8434349, @cscott wrote:

I think it's reasonable to ensure that the CSS rules have "class based" equivalents to the figure styling, eg figure[typeof=...], .enwiki-figure { ... }. I don't think I agree that that means we need to emit redundant class definitions in Parsoid HTML.

Some further points made to that effect:

figure[typeof=....], .mw-figure-xyz { ... } is cheap enough, has a minimal impact on performance, and allows future decoupling of parser output styling and template styling (such as in exactly the case we're discussing here).

it's also a one-time download of the highly-cacheable CSS, instead of bloating every figure in every article

the mw-figure-blahblah strings should also be very searchable, if we ever need to lint that content

Change 865213 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Bikeshed some classes to mimic the parser output

https://gerrit.wikimedia.org/r/865213

In T318433#8434348, @cscott wrote:

In T318433#8256434, @Izno wrote:

Tangentially (or maybe not), editors should have access to <figure> and <figcaption> in wikitext per my comment in T25932#7070297.

That's a separate debate, one on which I think there is a wide gap in consensus.

Without figure/figcaption literals though, templates won't actually be able to mimic the parser output for the block form. We're back to div soup,

<div class="enwiki-figure">
  <a href=""><img src="" /></a>
  <div class="enwiki-figcaption"></div>
</div>

Change 888127 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Change the default of wgParserEnableLegacyMediaDOM to false

https://gerrit.wikimedia.org/r/888127

In T318433#8458276, @Arlolra wrote:

In T318433#8434348, @cscott wrote:

In T318433#8256434, @Izno wrote:

Tangentially (or maybe not), editors should have access to <figure> and <figcaption> in wikitext per my comment in T25932#7070297.

That's a separate debate, one on which I think there is a wide gap in consensus.

Without figure/figcaption literals though, templates won't actually be able to mimic the parser output for the block form. We're back to div soup,

<div class="enwiki-figure">
  <a href=""><img src="" /></a>
  <div class="enwiki-figcaption"></div>
</div>

It may be that what we want is something like {{#figure|link=<link>|caption=<caption>|content=<content>}} (either as a built in or as an extension) which emits "the right figure structure" while allowing user content in the caption and in the "media" spot. The actual HTML representation would contain parsoid's standard tagging for "extension-generated content" as well as tagging for "user content" (cf https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/831077 for T309024; and T331655). For example:

<figure typeof="mw:Transclusion mw:File" ...>
  <a href="..."><span typeof="mw:UserContent">...parsed user wikitext...</span></a>
  <figcaption typeof="mw:UserContent">...parsed user wikitext...</figcaption>
</figure>

That would enforce the expected DOM structure on the user content and allow the reuse of typeof=mw:File in a safe (parser-generated typeof, not user-controlled) way. And, of course, if we ever made future tweaks to the media styling or DOM structure, we can make them in a single place in the {{#figure}} implementation and have them applied uniformly to user-generated content.

Change 888127 merged by jenkins-bot:

[mediawiki/core@master] Change the default of wgParserEnableLegacyMediaDOM to false

https://gerrit.wikimedia.org/r/888127

Change 901294 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_40] Change the default of wgParserEnableLegacyMediaDOM to false

https://gerrit.wikimedia.org/r/901294

Change 901294 merged by jenkins-bot:

[mediawiki/core@REL1_40] Change the default of wgParserEnableLegacyMediaDOM to false

https://gerrit.wikimedia.org/r/901294

Change 936799 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Add a config to stop shipping the legacy media styles

https://gerrit.wikimedia.org/r/936799

Change 937544 had a related patch set uploaded (by Arlolra; author: Arlolra):

[operations/mediawiki-config@master] Set default for UseLegacyMediaStyles and disable on officewiki

https://gerrit.wikimedia.org/r/937544

Change 936799 merged by jenkins-bot:

[mediawiki/core@master] Add a config to stop shipping the legacy media styles

https://gerrit.wikimedia.org/r/936799

Change 937544 merged by jenkins-bot:

[operations/mediawiki-config@master] Set default for UseLegacyMediaStyles and disable on officewiki

https://gerrit.wikimedia.org/r/937544

Mentioned in SAL (#wikimedia-operations) [2023-07-13T20:08:52Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:937544|Set default for UseLegacyMediaStyles and disable on officewiki (T318433)]]

Mentioned in SAL (#wikimedia-operations) [2023-07-13T20:10:19Z] <taavi@deploy1002> taavi and arlolra: Backport for [[gerrit:937544|Set default for UseLegacyMediaStyles and disable on officewiki (T318433)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-07-13T20:16:39Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:937544|Set default for UseLegacyMediaStyles and disable on officewiki (T318433)]] (duration: 07m 47s)

Change 939374 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[operations/mediawiki-config@master] Fix incorrect use of UseLegacyMediaStyles (missing "wg" prefix)

https://gerrit.wikimedia.org/r/939374

Change 939374 merged by jenkins-bot:

[operations/mediawiki-config@master] Fix incorrect use of UseLegacyMediaStyles (missing "wg" prefix)

https://gerrit.wikimedia.org/r/939374

Mentioned in SAL (#wikimedia-operations) [2023-07-19T13:02:52Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:939374|Fix incorrect use of UseLegacyMediaStyles (missing "wg" prefix) (T318433)]]

Mentioned in SAL (#wikimedia-operations) [2023-07-19T13:04:27Z] <lucaswerkmeister-wmde@deploy1002> ssastry and lucaswerkmeister-wmde: Backport for [[gerrit:939374|Fix incorrect use of UseLegacyMediaStyles (missing "wg" prefix) (T318433)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-07-19T13:13:40Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:939374|Fix incorrect use of UseLegacyMediaStyles (missing "wg" prefix) (T318433)]] (duration: 10m 47s)