We may want to consider to adjust the information on destinations hen an existing article exists, to make explicit that content will be overwritten.

The publish destination section will have an information icon that will open the corresponding documentation page in a new tab/window.

The information icon usually opens an help context popup in OOUI. Having it open a whole new tab may be unexpected.

In T197701#4862341, @Esanders wrote:

The publish destination section will have an information icon that will open the corresponding documentation page in a new tab/window.

The information icon usually opens an help context popup in OOUI. Having it open a whole new tab may be unexpected.

Good catch, @Esanders. Using a popup was the original plan, but given the clarifications needed we opted to use a dedicated documentation page instead.
I think the help (?) icon may be better suited for this case. I've updated the designs. Thanks!

Minor note, the planned icon (from screenshots in task description) is the 'helpNotice' icon.

Change 495162 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Show publish settings as a dialog

https://gerrit.wikimedia.org/r/495162

Change 495162 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Show publish settings as a dialog

https://gerrit.wikimedia.org/r/495162

Radio buttons should be vertically aligned to the top of their labels, as per the OOUI demo and T184526:

In T197701#5136175, @Esanders wrote:

Radio buttons should be vertically aligned to the top of their labels, as per the OOUI demo and T184526:

I was thinking of these as compound elements (name+description) rather than one element overflowing in two lines. But it's probably not worth it to make an exception for this. Radio buttons aligned on top look good here too. I'll update the mockups to avoid confusions. Thanks for the feedback!

On the patch, @Esanders has another question:

Should "Apply changes" be disabled if the radio hasn't been changed?

In T197701#5137005, @Petar.petkovic wrote:

On the patch, @Esanders has another question:

Should "Apply changes" be disabled if the radio hasn't been changed?

Yes. That would be preferred. When supporting that we need to carefully check the case where the user changed the translation title to use a different namespace that is not covered by the dialog options. In that case, none of the radio buttons will be selected initially and selecting one should enable the "Apply changes" button.

Regarding the alignment, here is the comparison of the default style and overrides I did to make it look like on mock-ups:

Default style	Overridden styles

In T197701#5136679, @Pginer-WMF wrote:

I was thinking of these as compound elements (name+description) rather than one element overflowing in two lines. But it's probably not worth it to make an exception for this. Radio buttons aligned on top look good here too. I'll update the mockups to avoid confusions. Thanks for the feedback!

Thanks, the more local style overrides we avoid the fewer regressions we get when OOUI changes :)

Change 495162 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Show publish settings as a dialog

https://gerrit.wikimedia.org/r/495162

After QA, this should be returned to In progress because

The main namespace option will be labelled as "New page" by default, but as "Replace the existing page" if a page with such title already exists in the main namespace

is still not completed.

The radio buttons look different in Chrome and FF (which I assume is ok):
Firefox:

Returning to 'In Progress' according to @Petar.petkovic comment:

In T197701#5143196, @Petar.petkovic wrote:

After QA, this should be returned to In progress because

The main namespace option will be labelled as "New page" by default, but as "Replace the existing page" if a page with such title already exists in the main namespace

is still not completed.

In T197701#5154797, @Etonkovidova wrote:

The radio buttons look different in Chrome and FF (which I assume is ok):
Firefox:

Chrome

Did you take screenshots from different wikis? There should not be difference between Chrome and Firefox on the same wiki and choosing draft namespace should only be an option for those wikis where the draft namespace is available, as the description says:

The option to publish in the Draft namespace, will be available only for those wikis where the draft namespace is available.

@Petar.petkovic - you're right! The difference that I saw in radio buttons only meant that the initial selection state (when clicked) then becomes a solid ring.

Change 507936 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Change label for main namespace in publish settings dialog when title exists

https://gerrit.wikimedia.org/r/507936

Change 507936 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Change label for main namespace in publish settings dialog when title exists

https://gerrit.wikimedia.org/r/507936