Page MenuHomePhabricator
Create Task
Maniphest T162768

CX2: Basic translation publishing and error handling
Closed, ResolvedPublic
Actions

Assigned To
• Petar.petkovic
Authored By
santhosh
Apr 12 2017, 4:51 AM
Tags
Referenced Files
F16927170: Screen Shot 2018-04-11 at 9.10.46 PM.png
Apr 12 2018, 4:39 AM
F16927187: Screen Shot 2018-04-09 at 5.01.31 PM.png
Apr 12 2018, 4:39 AM
F14282700: Screen Shot 2018-03-02 at 13.17.29.png
Mar 2 2018, 12:20 PM
F9848301: image.png
Sep 27 2017, 1:21 PM
F9848283: image.png
Sep 27 2017, 1:21 PM
Subscribers
Aklapper
Amire80
Esanders
Etonkovidova
gerritbot
Nikerabbit
Pginer-WMF
santhosh

Description

Support the basic functionality of publishing for the translation editor: clicking publish, creates a new page with the content of the translation:

  • The page will be created in the destination that indicates the title of the translation considering the namespace.
  • The published page will be linked in Wikidata to make it possible for users to navigate across languages.
  • If the destination page already exists, the content will be replaced with the new translation (other tickets will show warnings about this later).
  • The edit message will include a reference to the source article ("Created by translating the page X") and the "contenttranslation" tag as CX1 currently does.
  • If there is an issue during this process, it will be shown as an error.

We don't need to develop all translation tools before doing this. Once MT and link adaptation work is done, let us make sure the content publishes cleanly with all error handling.

Details

SubjectRepoBranchLines +/-
CX2: Basic error handlingmediawiki/extensions/ContentTranslationmaster+95 -114
Bring back publish namespace pickermediawiki/extensions/ContentTranslationmaster+40 -13
CX2: Publish the translationmediawiki/extensions/ContentTranslationmaster+23 -19
CX2: Fix the js error in publishing and show success messagemediawiki/extensions/ContentTranslationmaster+29 -9
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedsanthoshT152586 Reorganize the CX classes using OOjs/OOUI (tracker)
ResolvedPginer-WMFT188732 CX2: Publishing support
Resolved• Petar.petkovicT162768 CX2: Basic translation publishing and error handling
· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2017, 4:51 AM
Arrbee edited projects, added Language-team April-June 2017 (Language-2017 Sprint 6); removed Language-team April-June 2017 (Language-2017 Sprint 5).Apr 12 2017, 7:10 AM
Amire80 edited projects, added Language-team April-June 2017 (Language-2017 Sprint 7); removed Language-team April-June 2017 (Language-2017 Sprint 6).May 2 2017, 7:08 AM
santhosh removed santhosh as the assignee of this task.May 3 2017, 6:33 AM
santhosh removed a project: Language-team January-March 2017.
santhosh moved this task from Backlog to In Progress on the Language-team April-June 2017 (Language-2017 Sprint 7) board.May 10 2017, 10:58 AM
gerritbot subscribed.May 10 2017, 10:58 AM

Change 353040 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX2: Fix the js error in publishing and show success message

https://gerrit.wikimedia.org/r/353040

gerritbot added a project: Patch-For-Review.May 10 2017, 10:58 AM
gerritbot added a comment.May 10 2017, 1:56 PM

Change 353040 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Fix the js error in publishing and show success message

https://gerrit.wikimedia.org/r/353040

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 10 2017, 2:00 PM
santhosh moved this task from In Progress to Moved - next sprint/backlog on the Language-team April-June 2017 (Language-2017 Sprint 7) board.May 16 2017, 7:06 AM
Arrbee edited projects, added Language-team April-June 2017 (Language-2017 Sprint 8); removed Language-team April-June 2017 (Language-2017 Sprint 7).May 17 2017, 6:36 AM
santhosh moved this task from Backlog to In Progress on the Language-team April-June 2017 (Language-2017 Sprint 8) board.May 17 2017, 6:42 AM
Nikerabbit removed projects: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review.May 29 2017, 6:58 AM
Arrbee edited projects, added Language-team April-June 2017 (Language-2017 Sprint 9); removed Language-team April-June 2017 (Language-2017 Sprint 8).May 31 2017, 6:37 AM
Arrbee moved this task from Backlog to In Progress on the Language-team April-June 2017 (Language-2017 Sprint 9) board.May 31 2017, 6:39 AM
Amire80 moved this task from Needs Triage to Apr.–June 2017 on the ContentTranslation board.Jun 26 2017, 6:04 AM
Arrbee added a project: ContentTranslation-FY2017-18.Jun 27 2017, 3:21 PM
Arrbee moved this task from To Triage to CX-OOjs on the ContentTranslation-FY2017-18 board.
Arrbee added a project: Language-2017-July-Sept.Jul 3 2017, 7:18 AM
Arrbee moved this task from Backlog to In Progress on the Language-2017-July-Sept board.Jul 3 2017, 7:32 AM
Nikerabbit moved this task from In Progress to Backlog on the Language-2017-July-Sept board.Aug 22 2017, 7:18 AM
gerritbot added a comment.Sep 15 2017, 11:57 AM

Change 378030 had a related patch set uploaded (by Santhosh; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] CX2: Publish the translation

https://gerrit.wikimedia.org/r/378030

gerritbot added a project: Patch-For-Review.Sep 15 2017, 11:57 AM
santhosh claimed this task.Sep 15 2017, 11:57 AM

Publishing is working now with VE provided content from editor. There are some more testing I need to do for the title conflicts, overwrite warning and namespace selection. The success message banner also need some attention since it goes below the floating sticky headers

gerritbot added a comment.Sep 15 2017, 1:24 PM

Change 378030 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Publish the translation

https://gerrit.wikimedia.org/r/378030

Esanders mentioned this in T150652: Content Translation feature parity checklist post VisualEditor integration.Sep 15 2017, 1:53 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 15 2017, 2:00 PM
Arrbee moved this task from Backlog to In Progress on the Language-2017-July-Sept board.Sep 19 2017, 7:17 AM
Esanders subscribed.Sep 27 2017, 1:21 PM

In CX2 the error message is currently showing in two places:

image.png (182×1 px, 21 KB)

A persistent message like this is probably not the correct type for a fatal error that requires the user's immediate attention. For fatal errors we should show a modal dialog, such as this failure-to-load dialog in VE:

image.png (205×351 px, 13 KB)

Esanders added a comment.Sep 27 2017, 2:04 PM

For the less severe messages such as auto-save status, we can leave that at the top-of-page status bar.

Arrbee added a project: Language-2017-Oct-Dec.Oct 4 2017, 3:13 PM
Arrbee moved this task from Backlog to In Progress on the Language-2017-Oct-Dec board.
Arrbee moved this task from In Progress to Continued/Moved to future on the Language-2017-July-Sept board.Oct 4 2017, 3:23 PM
Arrbee moved this task from In Progress to Blocked on VE-CX on the Language-2017-Oct-Dec board.Oct 12 2017, 8:15 AM
Arrbee moved this task from Apr.–June 2017 to Oct-Dec 2017 on the ContentTranslation board.Oct 27 2017, 8:31 AM
Arrbee removed a project: Language-2017-Oct-Dec.Jan 5 2018, 1:02 PM
Arrbee moved this task from Oct-Dec 2017 to Blocked on VE-CX on the ContentTranslation board.Jan 5 2018, 1:12 PM
• Petar.petkovic removed a project: Patch-For-Review.Feb 15 2018, 8:52 AM
Pginer-WMF added a project: Language-2018-Jan-Mar.Feb 15 2018, 12:58 PM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-Jan-Mar board.Feb 16 2018, 7:30 AM
Pginer-WMF removed santhosh as the assignee of this task.Feb 19 2018, 8:14 AM
Pginer-WMF mentioned this in T187683: CX2: Investigate regressions in the translation editor.Feb 19 2018, 9:11 AM
Pginer-WMF updated the task description. (Show Details)Feb 19 2018, 9:24 AM
Arrbee moved this task from Priority backlog to Backlog on the Language-2018-Jan-Mar board.Feb 20 2018, 7:20 AM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-Jan-Mar board.Feb 26 2018, 2:26 PM
Pginer-WMF renamed this task from CX2: Translation publishing and error handling to CX2: Basic translation publishing and error handling.Feb 26 2018, 3:15 PM
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF subscribed.Mar 2 2018, 12:20 PM

I tried to publish in CX2 testing server the Nasothek article (tanslated from English to Spanish) and got the following error:

Screen Shot 2018-03-02 at 13.17.29.png (597×1 px, 160 KB)

Pginer-WMF mentioned this in T188732: CX2: Publishing support.Mar 2 2018, 1:44 PM
Pginer-WMF added a parent task: T188732: CX2: Publishing support.
Pginer-WMF assigned this task to • Petar.petkovic.Mar 5 2018, 8:24 AM
• Petar.petkovic moved this task from Blocked on VE-CX to CX2 on the ContentTranslation board.Mar 5 2018, 8:24 AM
• Petar.petkovic removed a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).
gerritbot added a comment.Mar 5 2018, 3:08 PM

Change 416447 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Bring back publish namespace picker

https://gerrit.wikimedia.org/r/416447

gerritbot added a project: Patch-For-Review.Mar 5 2018, 3:08 PM
• Petar.petkovic moved this task from Priority backlog to In Review on the Language-2018-Jan-Mar board.Mar 5 2018, 11:26 PM
gerritbot added a comment.Mar 8 2018, 1:42 AM

Change 417184 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] CX2: Basic error handling

https://gerrit.wikimedia.org/r/417184

gerritbot added a comment.Mar 13 2018, 6:04 AM

Change 416447 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Bring back publish namespace picker

https://gerrit.wikimedia.org/r/416447

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 13 2018, 7:00 AM
Pginer-WMF added a project: Language-2018-Apr-June.Apr 3 2018, 8:19 AM
Pginer-WMF moved this task from Backlog to In Review on the Language-2018-Apr-June board.
Pginer-WMF removed a project: Language-2018-Jan-Mar.Apr 3 2018, 8:23 AM
• Petar.petkovic mentioned this in T189291: CX2: Communicate publishing is in progress.Apr 3 2018, 10:38 PM
gerritbot added a comment.Apr 5 2018, 6:53 AM

Change 417184 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Basic error handling

https://gerrit.wikimedia.org/r/417184

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)); removed MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Apr 5 2018, 7:00 AM
Arrbee moved this task from In Review to QA on the Language-2018-Apr-June board.Apr 5 2018, 8:03 AM
• Petar.petkovic removed a project: Patch-For-Review.Apr 5 2018, 8:05 AM
Etonkovidova subscribed.Apr 12 2018, 4:39 AM

Publishing works successfully according to specs with only few issues.

@santhosh and @Pginer-WMF The issues seem to be kind of out of the overall scope of this task. Should be there separate tickets?
(1) When "[CX] Invalid target title" Console error is shown, there is no indication to a user that the title needs to be corrected. The article will be published with the previous valid title or defaults to the title of the article being translated.
(2) Another case for error handling - when a user session is expired. The Publish icon remains active but no action can be performed:

Screen Shot 2018-04-09 at 5.01.31 PM.png (319×1 px, 63 KB)

(3) A warning to a user looks a little bit unbalanced in terms of space between lines and centering of the text. Also referring to "replacing the existing page" made me think that the source page might be replaced.
Screen Shot 2018-04-11 at 9.10.46 PM.png (383×945 px, 56 KB)

Pginer-WMF added a comment.Apr 12 2018, 10:28 AM
In T162768#4125869, @Etonkovidova wrote:

(1) When "[CX] Invalid target title" Console error is shown, there is no indication to a user that the title needs to be corrected. The article will be published with the previous valid title or defaults to the title of the article being translated.

Is "[CX] Invalid target title" only produced when there are invalid characters in the title? If that is the case, we have a ticket to deal with such case (T190804). If not, we may want to create a ticket and describe which is the cause of such error.

(2) Another case for error handling - when a user session is expired. The Publish icon remains active but no action can be performed:

Screen Shot 2018-04-09 at 5.01.31 PM.png (319×1 px, 63 KB)

Thanks for caching this. I created a separate ticket with the info you provided (T192066), and will work on the designs for it later.

(3) A warning to a user looks a little bit unbalanced in terms of space between lines and centering of the text. Also referring to "replacing the existing page" made me think that the source page might be replaced.

Screen Shot 2018-04-11 at 9.10.46 PM.png (383×945 px, 56 KB)

These changes are part of T190038, we can further comment on those there.

Pginer-WMF mentioned this in T190038: CX2: Warning when page title already exists.Apr 12 2018, 10:35 AM
• Petar.petkovic added a comment.Apr 12 2018, 11:48 AM
In T162768#4125869, @Etonkovidova wrote:

@santhosh and @Pginer-WMF The issues seem to be kind of out of the overall scope of this task. Should be there separate tickets?

There actually is a separate ticket for everything listed.

(1) When "[CX] Invalid target title" Console error is shown, there is no indication to a user that the title needs to be corrected. The article will be published with the previous valid title or defaults to the title of the article being translated.

I'm dealing with this in T191349, which is meant to restore what we have in CX1 - when user tries to publish with invalid target title, error is displayed. T190804 is set to indicate which characters are wrong and prohibit publishing if there are invalid characters in target title.

(2) Another case for error handling - when a user session is expired. The Publish icon remains active but no action can be performed:

Screen Shot 2018-04-09 at 5.01.31 PM.png (319×1 px, 63 KB)

There was no ticket for this specific case at the time you wrote the comment, but @Pginer-WMF created T192066 after that.

I would add that behavior is coming from "If publishing failed or warnings were shown, the publishing button will become enabled, allowing to try to publish again without the need for making further changes" which is described in T189291. Also, in this patch, I have introduced recoverable and unrecoverable errors, but that is yet unused. It can be used to disable publish button if error which occurred is unrecoverable.

(3) A warning to a user looks a little bit unbalanced in terms of space between lines and centering of the text. Also referring to "replacing the existing page" made me think that the source page might be replaced.

Screen Shot 2018-04-11 at 9.10.46 PM.png (383×945 px, 56 KB)

As @Pginer-WMF noted, this is part of T190038.

Etonkovidova closed this task as Resolved.Apr 18 2018, 6:25 PM

Thanks @Pginer-WMF and @Petar.petkovic for your clarifications on my comment. Closing this ticket as Resolved.

• Petar.petkovic moved this task from QA to Done on the Language-2018-Apr-June board.Apr 18 2018, 9:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL