Page MenuHomePhabricator

Bug 1870145 - use moz-message-bar for the Firefox suggest info message r=#recomp-reviewers,#preferences-reviewers
AcceptedPublic

Authored by hjones on Dec 14 2023, 9:25 PM.

Details

Reviewers
mconley
tgiles
Bugzilla Bug ID
1870145
Summary

This is just a little experiment to see how easy it would be to switch some of these messages to use moz-message-bar. If we think this works well then I'll file a handful of bugs to tackle similar UI, all of which should be pretty contributor friendly (I can point to this patch for reference).

There are a couple of changes to moz-message-bar to make the conversion easier - these are actually copied from work in D189872 which I'll likely land first (sometime early next year, so no rush on this).

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptDec 14 2023, 9:26 PM

For easy local testing you can toggle on the browser.urlbar.quicksuggest.enabled pref.

How it looks in context:

Screenshot 2023-12-14 at 4.30.39 PM.png (1×1 px, 214 KB)

toolkit/content/widgets/moz-message-bar/moz-message-bar.mjs
47 ↗(On Diff #800162)

all the changes to this file will likely actually come from here

remove unnecessary data-l10n-attrs

mconley edited reviewers, added: mconley; removed: Restricted Project.Dec 18 2023, 8:22 PM
mconley added a project: testing-approved.

This looks great to me! I guess let's rebase this after D189872 merges. But the browser/components/preferences part looks great!

tgiles added a subscriber: tgiles.

Looks good to me, thanks for the patch!

This revision is now accepted and ready to land.Jan 5 2024, 8:02 PM
hjones edited the summary of this revision. (Show Details)

rebase, move changes to new files