Skip to content

Commit

Permalink
Fix wrong value of playerState (#386)
Browse files Browse the repository at this point in the history
- Fix bug introduced by e9dbe9e regarding mapping of player state. The value returned from the player has a lower-bound of "-1", whereas YTPlayerState is a 0-based NSInteger enum.
- Remove redundant code
  • Loading branch information
denkeni committed Jun 25, 2020
1 parent a609393 commit 174eca2
Showing 1 changed file with 2 additions and 17 deletions.
19 changes: 2 additions & 17 deletions Classes/YTPlayerView.m
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ - (void)playerState:(_Nullable YTPlayerStateCompletionHandler)completionHandler
completionHandler(kYTPlayerStateUnknown, error);
return;
}
YTPlayerState state = [result intValue];
YTPlayerState state = [YTPlayerView playerStateForString:[result stringValue]];
completionHandler(state, nil);
}];
}
Expand Down Expand Up @@ -579,22 +579,7 @@ - (void)notifyDelegateOfYouTubeCallbackUrl:(NSURL *) url {
}
} else if ([action isEqual:kYTPlayerCallbackOnStateChange]) {
if ([self.delegate respondsToSelector:@selector(playerView:didChangeToState:)]) {
YTPlayerState state = kYTPlayerStateUnknown;

if ([data isEqual:kYTPlayerStateEndedCode]) {
state = kYTPlayerStateEnded;
} else if ([data isEqual:kYTPlayerStatePlayingCode]) {
state = kYTPlayerStatePlaying;
} else if ([data isEqual:kYTPlayerStatePausedCode]) {
state = kYTPlayerStatePaused;
} else if ([data isEqual:kYTPlayerStateBufferingCode]) {
state = kYTPlayerStateBuffering;
} else if ([data isEqual:kYTPlayerStateCuedCode]) {
state = kYTPlayerStateCued;
} else if ([data isEqual:kYTPlayerStateUnstartedCode]) {
state = kYTPlayerStateUnstarted;
}

YTPlayerState state = [YTPlayerView playerStateForString:data];
[self.delegate playerView:self didChangeToState:state];
}
} else if ([action isEqual:kYTPlayerCallbackOnPlaybackQualityChange]) {
Expand Down

0 comments on commit 174eca2

Please sign in to comment.