Skip to content

Base rule extension: [max-params] don't count this: void #7538

Closed
@RettentoRectangle

Description

@RettentoRectangle

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • My proposal specifically checks TypeScript syntax, or it proposes a check that requires type information to be accurate.
  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the base rule

https://eslint.org/docs/latest/rules/max-params

Description

It would be great ignore "this: void" by default.

Eslint cries about "this: void" even though it is not a real parameter.

Fail

// Fail. Still report an error if too much parameters are there:

private doSomethingWild (x: number, y: number, z: number, k: any) {
 //
}

Pass

// Pass. Don't count "this: void".

private doSomethingWild (this: void, x: number, y: number, z: number) {
 //
}

Additional Info

I don't have time to make it myself. :(

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueenhancement: new base rule extensionNew base rule extension required to handle a TS specific casepackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions