Skip to content

[await-thenable] warn against passing non-promise values to promise aggregators (Promise.all, Promise.allSettled, Promise.race) #1804

Open
@viestat

Description

@viestat

Repro

{
  "rules": {
    "@typescript-eslint/await-thenable": "error"
  }
}
const value = 'value';
const createValue = () => 'value';

await Promise.all([value, createValue]);

Expected Result
The rule should show a linting error:

Unexpected `await` of a non-Promise (non-"Thenable") value  @typescript-eslint/await-thenable

Actual Result
No liniting error.

Additional Info

Versions

package version
@typescript-eslint/eslint-plugin 2.24.0
@typescript-eslint/parser 2.24.0
TypeScript 3.8.3
ESLint 6.8.0
node 12.10.0
npm 6.10.3

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueenhancement: plugin rule optionNew rule option for an existing eslint-plugin rulepackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions