Skip to content

Bug: [no-unnecessary-type-conversion] shouldn't have fixable property #11192

Closed
@mho22

Description

@mho22

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Same as issue #10988.

Rule no-unnecessary-type-conversion has fixable: 'code' and hasSuggestions: true properties in meta at line 31 :

    fixable: 'code',
    hasSuggestions: true,

But each fix is located in a suggest property on line 84, 89, 127, 140, 179, 184, 218, 223, 279, 284, 217 and 322 :

example on line 81 :

suggest: [
    {
        messageId: 'suggestRemove',
        fix: getWrappingFixer(wrappingFixerParams),
    },
    {
        messageId: 'suggestSatisfies',
        data: { type: typeString },
        fix: getWrappingFixer({
            ...wrappingFixerParams,
            wrap: expr => `${expr} satisfies ${typeString}`,
        }),
    },
],

Based on eslint documentation :

fixable: (string) Either "code" or "whitespace" if the --fix option on the command line automatically fixes problems reported by the rule.

Since fixable means "automatic fix" with --fix I suppose fixable is no more needed in this rule.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions