Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: replicate/replicate-javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.34.0
Choose a base ref
...
head repository: replicate/replicate-javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.34.1
Choose a head ref
  • 3 commits
  • 5 files changed
  • 3 contributors

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    be0f323 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Bug fixes for the wait option in replicate.run (#315)

    There were a couple of small bugs in the current implementation:
    
    1. We would pass non-boolean, non-integer values through to `predictions.create` when it was an object with an interval, resulting in the blocking mode being used accidentally.
    2. We would pass the boolean/integer values through to `wait` which would create a runtime error when the `wait` function expects an object.
    3. We continued to poll for the prediction despite the blocking response returning the output data.
    
    This PR addresses these three issues by checking if the run should be blocking and passing the correct arguments in the correct places. We also assume that if the returned prediction is not in `starting` state then it is completed. This isn't ideal but works for the moment.
    
    Lastly, in  the case where the blocking request times out the client will fall back to polling at the default interval.
    aron authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c1a12b0 View commit details
    Browse the repository at this point in the history
  2. 0.34.1

    mattt committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a7dfbfd View commit details
    Browse the repository at this point in the history
Loading