Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mrunalp/fileutils
base: v0.5.0
Choose a base ref
...
head repository: mrunalp/fileutils
compare: v0.5.1
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Oct 4, 2023

  1. MkdirAllNewAs,CopyDirectory: ensure dir perms 

    Because of umask, sometimes newly created files and directories can have
permission bits different than expected. An easy solution would be to call
os.Chmod after creation -- this is how CopyFile already works.

Now, let's do the same for directories.

PS The alternative to that would be to temporary set umask to 0, but it
is very problematic in Go as it affects other threads.

Signed-off-by: Kir Kolyshkin <[email protected]>
    @kolyshkin
    kolyshkin committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e3d1947 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #9 from kolyshkin/fix-dir-perms 

    MkdirAllNewAs,CopyDirectory: ensure dir perms
    @mrunalp
    mrunalp committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    7363e97 View commit details
    Browse the repository at this point in the history