Skip to content

[NFC][HLSL] Move resource range logic from SemaHLSL to RootSignatureValidations #146393

Open
@inbelic

Description

@inbelic

This issue tracks the work to abstract out the logic of detecting resource range overlap from SemaHLSL into the RootSignatureValidations library.

This logic includes the detection of if the ResourceClass, space and visibility are overlapping and thus the underlying ranges overlap contained in the handleHLSLRootSignatureDecl function here.

This is a non-functional change, but it will require a slight change to the RangeInfo structure such that each RangeInfo can be mapped back to its RootElement. The proposed solution is to use an Index on each RangeInfo that will retain this.

AC:

  • Update RangeInfo to have an Index field that can be used to map back to its relevant diagnostic information
  • Move the validation logic from SemaHLSL to RootSignatureValidations
  • Update SemaHLSL to use the new interface for the validations

Metadata

Metadata

Assignees

Labels

HLSLHLSL Language Support

Type

No type

Projects

Status

Planning

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions