Skip to content

Plugins: settings fields that are secure are unable to be set on keychain #10526

Closed
@alondmnt

Description

@alondmnt

Operating system

Windows

Joplin version

2.14.22

Desktop version info

Joplin 2.14.22 (prod, win32)
Client ID: 19f20674be77445bbd5535190049d93c
Sync Version: 3
Profile Version: 46
Keychain Supported: Yes
Revision: e579eb9

Current behaviour

This was first reported by @djsudduth in this Jarvis plugin issue.

  1. The plugin tries to set API keys (secure: true fields) into the ketchain service.
  2. In the development tools console the following exception appears:

models/Setting: Could not set setting on the keychain. Will be saved to database instead: plugin-joplin.plugin.alondmnt.jarvis.springer_api_key: Error: Password is required.

Setting secure: false resolves the error.

Expected behaviour

No error.

Logs

models/Setting: Could not set setting on the keychain. Will be saved to database instead: plugin-joplin.plugin.alondmnt.jarvis.hf_api_key: Error: Password is required.
at checkRequired (C:\Users\myusername\AppD…\lib\keytar.js:5:11)
at Object.setPassword (C:\Users\myusername\AppD…\lib\keytar.js:20:5)
at KeychainServiceDriver. (C:\Users\myusername\AppD…river.node.js:19:43)
at Generator.next ()
at C:\Users\myusername\AppD…Driver.node.js:8:71
at new Promise ()
at __awaiter (C:\Users\myusername\AppD…Driver.node.js:4:12)
at KeychainServiceDriver.setPassword (C:\Users\myusername\AppD…river.node.js:16:16)
at KeychainService. (C:\Users\myusername\AppD…ainService.js:51:32)
at Generator.next ()

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIt's a bugdesktopAll desktop platformshighHigh priority issues

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions