Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.19.4
Choose a base ref
...
head repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.19.5
Choose a head ref
  • 5 commits
  • 4 files changed
  • 3 contributors

Commits on Jan 20, 2025

  1. cache: clone maps to prevent data race when concurrently creating cac… 

    …hes using the same options
    @chrischdi
    chrischdi authored and k8s-infra-cherrypick-robot committed Jan 20, 2025
    Configuration menu
    Copy the full SHA
    2ae6e55 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3080 from k8s-infra-cherrypick-robot/cherry-pick-… 

    …3078-to-release-0.19

[release-0.19] 🐛 cache: clone maps to prevent data race when concurrently creating caches using the same options
    @k8s-ci-robot
    k8s-ci-robot authored Jan 20, 2025
    Configuration menu
    Copy the full SHA
    d4df90f View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2025

  1. 🐛fix(controller): support WaitForSync in custom TypedSyncingSource (#… 

    …3084)

* 🐛fix(controller): use generic WaitForSync

There is already support for defining `TypedSyncingSource` but the original code still checks for the original `SyncingSource` before callign `WaitForSync(ctx)` which does not work for custom typed controller.

this fix should be backported to v0.19

* test
    @tareksha
    tareksha authored and Tarek Sharafi committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    8017666 View commit details
    Browse the repository at this point in the history

  2. Update controller_suite_test.go

    @tareksha
    tareksha authored Jan 23, 2025
    Configuration menu
    Copy the full SHA
    b2c2171 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #3087 from tareksha/typed_waitforsync 

    [release-0.19] 🐛fix(controller): support WaitForSync in custom TypedSyncingSource
    @k8s-ci-robot
    k8s-ci-robot authored Jan 23, 2025
    Configuration menu
    Copy the full SHA
    e022b91 View commit details
    Browse the repository at this point in the history
Loading