Skip to content

verify-featuregates.sh: include instructions in failure message #132553

Open
@pohly

Description

@pohly

What would you like to be added?

When verify-featuregates.sh fails, its stderr is captured, shown in spyglass:

verify: featuregates
{ ScriptError 
see stderr for details
}

But stderr only shows:

Failed to verify versioned feature list: 
detected diff in versioned feature list (test/compatibility_lifecycle/reference/versioned_feature_list.yaml), diff: 
  []uint8(
  	"""
  	... // 471 identical lines
  	    preRelease: Beta
  	    version: "1.33"
- 	- name: DRASchedulerFilterTimeout
- 	  versionedSpecs:
- 	  - default: true
- 	    lockToDefault: false
- 	    preRelease: Beta
- 	    version: "1.34"
  	- name: DynamicResourceAllocation
  	  versionedSpecs:
  	... // 1281 identical lines
  	"""
  )
exit status 1

The crucial hint Please run 'hack/update-featuregates.sh' to update the feature list. is only visible in the full job log. It should be printed to stderr instead of stdout.

Example: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/132033/pull-kubernetes-verify/1938133365362266112

Why is this needed?

Easier handling of CI failures.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions