Skip to content

add alphabetization linter #130779

Closed
Closed
@danwinship

Description

@danwinship

There are a handful of files containing a list of variables that is intended to be kept sorted, including at least

  • pkg/features/kube_features.go (❌)
  • pkg/features/versioned_kube_features.go (❌)
  • staging/src/k8s.io/client-go/features/known_features.go
  • staging/src/k8s.io/apiserver/pkg/features/kube_features.go (❌)
  • staging/src/k8s.io/controller-manager/pkg/features/kube_features.go
  • staging/src/k8s.io/apiextensions-apiserver/pkg/features/kube_features.go
  • test/e2e/feature/feature.go (❌)
  • test/e2e/environment/environment.go

The ones marked ❌ are currently not sorted in master (and the other ones only have 1 or 2 elements in them and would presumably be unsorted if they were longer).

Someone should write a linter that checks this.

/area code-organization
/help

Metadata

Metadata

Assignees

Labels

area/code-organizationIssues or PRs related to kubernetes code organizationhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.sig/architectureCategorizes an issue or PR as relevant to SIG Architecture.sig/testingCategorizes an issue or PR as relevant to SIG Testing.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions