Skip to content

The problem with the event recorder is that it runs (sic!) goroutines. #128282

Closed as not planned
@carlory

Description

@carlory

The problem with the event recorder is that it runs (sic!) goroutines. That makes initializing it in the Run method more suitable because then there is a proper context for those goroutines (cancellation!).

What was problematic with 50c1243 was that it left the event recorder as field in the controller struct. Usage of that field in the event handler then became a runtime problem instead of a compile-time error.

If I were to do this again, I would probably remove the recorder field and turn it into a parameter of the functions called by Run.

Originally posted by @pohly in #128179 (comment)

Metadata

Metadata

Assignees

Labels

kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.sig/nodeCategorizes an issue or PR as relevant to SIG Node.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions