add pod containers[*].port duplicate warning

pacoxu · pacoxu · commit a3f578db0a94 · 2022-10-21T16:06:40.000+08:00
diff --git a/pkg/api/pod/warnings.go b/pkg/api/pod/warnings.go
@@ -243,6 +243,17 @@ func warningsForPodSpecAndMeta(fieldPath *field.Path, podSpec *api.PodSpec, meta
 				}
 			}
 		}
+		// duplicate containers[*].ports
+		if len(c.Ports) > 1 {
+			ports := sets.NewInt64()
+			for i, port := range c.Ports {
+				if ports.Has(int64(port.ContainerPort)) {
+					warnings = append(warnings, fmt.Sprintf("%s: duplicate container port %d", p.Child("ports").Index(i).Child("containerPort"), port.ContainerPort))
+				} else {
+					ports.Insert(int64(port.ContainerPort))
+				}
+			}
+		}
 		return true
 	})
 
diff --git a/pkg/api/pod/warnings_test.go b/pkg/api/pod/warnings_test.go
@@ -459,6 +459,58 @@ func TestWarnings(t *testing.T) {
 			},
 			expected: []string{},
 		},
+		{
+			name: "no duplicate container ports",
+			template: &api.PodTemplateSpec{Spec: api.PodSpec{
+				Containers: []api.Container{{
+					Name: "foo",
+					Ports: []api.ContainerPort{
+						{ContainerPort: 80, HostPort: 80},
+					},
+				}},
+			}},
+			expected: []string{},
+		},
+		{
+			name: "duplicate container ports",
+			template: &api.PodTemplateSpec{Spec: api.PodSpec{
+				Containers: []api.Container{{
+					Name: "foo",
+					Ports: []api.ContainerPort{
+						{ContainerPort: 80, HostPort: 80},
+						{ContainerPort: 80, HostPort: 80},
+					},
+				}},
+			}},
+			expected: []string{
+				`spec.containers[0].ports[1].containerPort: duplicate container port 80`,
+			},
+		},
+		{
+			name: "duplicate container ports in two containers",
+			template: &api.PodTemplateSpec{Spec: api.PodSpec{
+				Containers: []api.Container{
+					{
+						Name: "foo1",
+						Ports: []api.ContainerPort{
+							{ContainerPort: 80, HostPort: 80},
+							{ContainerPort: 180, HostPort: 80},
+							{ContainerPort: 80, HostPort: 80},
+						},
+					},
+					{
+						Name: "foo",
+						Ports: []api.ContainerPort{
+							{ContainerPort: 80, HostPort: 80},
+							{ContainerPort: 80, HostPort: 80},
+						},
+					}},
+			}},
+			expected: []string{
+				`spec.containers[0].ports[2].containerPort: duplicate container port 80`,
+				`spec.containers[1].ports[1].containerPort: duplicate container port 80`,
+			},
+		},
 	}
 
 	for _, tc := range testcases {

Original file line number	Diff line number	Diff line change
`@@ -243,6 +243,17 @@ func warningsForPodSpecAndMeta(fieldPath field.Path, podSpec api.PodSpec, meta`
`243`	`243`	`}`
`244`	`244`	`}`
`245`	`245`	`}`
	`246`	`+ // duplicate containers[*].ports`
	`247`	`+ if len(c.Ports) > 1 {`
	`248`	`+ ports := sets.NewInt64()`
	`249`	`+ for i, port := range c.Ports {`
	`250`	`+ if ports.Has(int64(port.ContainerPort)) {`
	`251`	`+ warnings = append(warnings, fmt.Sprintf("%s: duplicate container port %d", p.Child("ports").Index(i).Child("containerPort"), port.ContainerPort))`
	`252`	`+ } else {`
	`253`	`+ ports.Insert(int64(port.ContainerPort))`
	`254`	`+ }`
	`255`	`+ }`
	`256`	`+ }`
`246`	`257`	`return true`
`247`	`258`	`})`
`248`	`259`