Skip to content

Commit 37f7261

Browse files
connorjclarkpaulirish
connorjclark
authored and
paulirish
committed
report: naming convention (#9149) followup fixes
1 parent 016085c commit 37f7261

File tree

2 files changed

+26
-26
lines changed

2 files changed

+26
-26
lines changed

‎lighthouse-core/report/html/report-styles.css

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
color of that hue.
3434
*/
3535
.lh-vars {
36-
--text-font-family: Roboto, Helvetica, Arial, sans-serif;
37-
--monospace-font-family: 'Roboto Mono', 'Menlo', 'dejavu sans mono', 'Consolas', 'Lucida Console', monospace;
36+
--report-font-family: Roboto, Helvetica, Arial, sans-serif;
37+
--report-font-family-monospace: 'Roboto Mono', 'Menlo', 'dejavu sans mono', 'Consolas', 'Lucida Console', monospace;
3838
--report-background-color: #fff;
3939
--report-text-color: var(--color-gray-900);
4040
--report-font-size: 16px;
@@ -47,10 +47,10 @@
4747
--footer-padding-vertical: 16px;
4848
--audit-margin-horizontal: 5px;
4949
--stackpack-padding-horizontal: 10px;
50-
--secondary-text-color: var(--color-gray-800);
51-
--informative-color: var(--color-blue-900);
50+
--report-text-color-secondary: var(--color-gray-800);
51+
--color-informative: var(--color-blue-900);
5252
--snippet-background-color: var(--color-gray-50);
53-
--report-secondary-border-color: #ebebeb;
53+
--report-border-color-secondary: #ebebeb;
5454
--chevron-line-stroke: var(--color-gray-600);
5555
--report-width: calc(60 * var(--report-font-size));
5656
--report-min-width: 400px;
@@ -173,15 +173,15 @@
173173
--topbar-background-color: var(--color-gray);
174174
--plugin-badge-background-color: var(--color-gray-800);
175175
--env-item-background-color: var(--color-gray);
176-
--report-secondary-border-color: var(--color-gray-200);
176+
--report-border-color-secondary: var(--color-gray-200);
177177

178178
--report-background-color: var(--color-gray-900);
179179
--report-text-color: var(--color-gray-100);
180-
--secondary-text-color: var(--color-gray-400);
180+
--report-text-color-secondary: var(--color-gray-400);
181181

182182
--plugin-icon-url: var(--plugin-icon-url-dark);
183183

184-
--informative-color: var(--color-blue-200);
184+
--color-informative: var(--color-blue-200);
185185

186186
--color-gray-50: #757575;
187187

@@ -225,8 +225,8 @@
225225
}
226226

227227
.lh-vars.lh-devtools {
228-
--text-font-family: '.SFNSDisplay-Regular', 'Helvetica Neue', 'Lucida Grande', sans-serif;
229-
--monospace-font-family: 'Menlo', 'dejavu sans mono', 'Consolas', 'Lucida Console', monospace;
228+
--report-font-family: '.SFNSDisplay-Regular', 'Helvetica Neue', 'Lucida Grande', sans-serif;
229+
--report-font-family-monospace: 'Menlo', 'dejavu sans mono', 'Consolas', 'Lucida Console', monospace;
230230
--report-font-size: 12px;
231231
--report-line-height: 20px;
232232
--category-header-font-size: 16px;
@@ -282,7 +282,7 @@
282282
}
283283

284284
.lh-root {
285-
font-family: var(--text-font-family);
285+
font-family: var(--report-font-family);
286286
font-size: var(--report-font-size);
287287
margin: 0;
288288
line-height: var(--report-line-height);
@@ -332,7 +332,7 @@
332332
.lh-category-header__description a,
333333
.lh-audit__description a,
334334
.lh-footer a {
335-
color: var(--informative-color);
335+
color: var(--color-informative);
336336
}
337337

338338
.lh-audit__description, .lh-audit__stackpack {
@@ -397,7 +397,7 @@
397397

398398
/* Node */
399399
.lh-node__snippet {
400-
font-family: var(--monospace-font-family);
400+
font-family: var(--report-font-family-monospace);
401401
color: var(--color-teal-600);
402402
font-size: 12px;
403403
line-height: 1.5em;
@@ -463,7 +463,7 @@
463463

464464
.lh-audit__description,
465465
.lh-audit__stackpack {
466-
color: var(--secondary-text-color);
466+
color: var(--report-text-color-secondary);
467467
}
468468
.lh-category-header__description {
469469
font-size: var(--report-font-size);
@@ -566,10 +566,10 @@
566566

567567

568568
.lh-metric {
569-
border-bottom: 1px solid var(--report-secondary-border-color);
569+
border-bottom: 1px solid var(--report-border-color-secondary);
570570
}
571571
.lh-metric:first-of-type {
572-
border-top: 1px solid var(--report-secondary-border-color);
572+
border-top: 1px solid var(--report-border-color-secondary);
573573
}
574574

575575
.lh-metric__innerwrap {
@@ -596,7 +596,7 @@
596596

597597
.lh-metric__description {
598598
display: none;
599-
color: var(--secondary-text-color);
599+
color: var(--report-text-color-secondary);
600600
padding: var(--metric-description-padding);
601601
}
602602

@@ -797,7 +797,7 @@
797797
}
798798

799799
.lh-filmstrip__thumbnail {
800-
border: 1px solid var(--report-secondary-border-color);
800+
border: 1px solid var(--report-border-color-secondary);
801801
max-height: 100px;
802802
max-width: 60px;
803803
}
@@ -819,12 +819,12 @@
819819
/* Audit */
820820

821821
.lh-audit {
822-
border-bottom: 1px solid var(--report-secondary-border-color);
822+
border-bottom: 1px solid var(--report-border-color-secondary);
823823
}
824824

825825
/* Apply border-top to just the first audit. */
826826
.lh-audit {
827-
border-top: 1px solid var(--report-secondary-border-color);
827+
border-top: 1px solid var(--report-border-color-secondary);
828828
}
829829
.lh-audit ~ .lh-audit {
830830
border-top: none;
@@ -995,7 +995,7 @@
995995

996996
.lh-warnings--toplevel {
997997
--item-margin: calc(var(--header-line-height) / 4);
998-
color: var(--secondary-text-color);
998+
color: var(--report-text-color-secondary);
999999
margin: var(--category-padding);
10001000
padding: var(--category-padding);
10011001
}
@@ -1103,7 +1103,7 @@
11031103
width: 100%;
11041104
height: var(--gauge-circle-size);
11051105
position: absolute;
1106-
font-family: var(--monospace-font-family);
1106+
font-family: var(--report-font-family-monospace);
11071107
font-size: calc(var(--gauge-circle-size) * 0.34 + 1.3px);
11081108
line-height: 0;
11091109
text-align: center;
@@ -1171,7 +1171,7 @@
11711171
display: flex;
11721172
align-items: center;
11731173
margin: 0 12px;
1174-
font-family: var(--monospace-font-family);
1174+
font-family: var(--report-font-family-monospace);
11751175
white-space: nowrap;
11761176
}
11771177

‎lighthouse-core/report/html/templates.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -817,7 +817,7 @@
817817
border-bottom: none;
818818
color: var(--snippet-color);
819819
background-color: var(--snippet-background-color);
820-
border: 1px solid var(--report-secondary-border-color);
820+
border: 1px solid var(--report-border-color-secondary);
821821
}
822822
.lh-snippet__title {
823823
font-weight: bold;
@@ -841,7 +841,7 @@
841841

842842
.lh-snippet__snippet {
843843
overflow: auto;
844-
border: 1px solid var(--report-secondary-border-color);
844+
border: 1px solid var(--report-border-color-secondary);
845845
}
846846
/* Container needed so that all children grow to the width of the scroll container */
847847
.lh-snippet__snippet-inner {
@@ -881,7 +881,7 @@
881881
padding: 10px;
882882
padding-left: 5px;
883883
color: var(--color-fail);
884-
font-family: var(--text-font-family);
884+
font-family: var(--report-font-family);
885885
}
886886
.lh-snippet__line--message code {
887887
white-space: normal;

0 commit comments

Comments
 (0)