Skip to content

Bug introduced in v3.12.0 #1838

Closed
Closed
@jacek-jablonski

Description

@jacek-jablonski

Hi,

I think a bug was introduced in v3.12.0, it this commit: 3645e32#diff-80c3339e876a6651c796df9b6621e6c8fba7d8b168f65239753398a0441b06a9R1345

isinstance(someinteger, object) called like that is always True, because int is an instance of an object:

>>> isinstance(3, object)
True

As a result, the timeout is always changed to None at this point. This causes timeout to not be respected when for example QueryJob.exception method is called.

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: bigqueryIssues related to the googleapis/python-bigquery API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions