fix: only record retry count when it's > 0 (#1488)

* fix: only record retry count when it's > 0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · Nov 1, 2022 · 445a667 · 445a667
1 parent e67ac61
commit 445a667
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java b/...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java
@@ -232,7 +232,11 @@ private void recordOperationCompletion(@Nullable Throwable status) {
  operationTimer.stop();
  long operationLatency = operationTimer.elapsed(TimeUnit.MILLISECONDS);
 
- recorder.putRetryCount(attemptCount - 1);
+ // Only record when retry count is greater than 0 so the retry
+ // graph will be less confusing
+ if (attemptCount > 1) {
+ recorder.putRetryCount(attemptCount - 1);
+ }
 
  // serverLatencyTimer should already be stopped in recordAttemptCompletion
  recorder.putOperationLatencies(operationLatency);

diff --git a/...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BuiltinMetricsIT.java b/...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BuiltinMetricsIT.java
@@ -48,7 +48,6 @@ public class BuiltinMetricsIT {
 
  public static String[] VIEWS = {
  "operation_latencies",
- "retry_count",
  "attempt_latencies",
  "connectivity_error_count",
  "application_blocking_latencies"