fix(storage): retry unwrapped EOFs (#12202)

BrennaEpp · web-flow · commit b2d42bda6a39 · 2025-05-12T00:24:31.000-07:00
diff --git a/storage/invoke.go b/storage/invoke.go
@@ -170,6 +170,15 @@ func ShouldRetry(err error) bool {
 				return true
 			}
 		}
+		// TODO: remove when https://github.com/golang/go/issues/53472 is resolved.
+		// We don't want to retry io.EOF errors, since these can indicate normal
+		// functioning terminations such as internally in the case of Reader and
+		// externally in the case of iterator methods. However, the linked bug
+		// requires us to retry EOFs that it causes. We can distinguish
+		// EOFs caused by the bug because they are not wrapped correctly.
+		if !errors.Is(err, io.EOF) && strings.Contains(err.Error(), "EOF") {
+			return true
+		}
 	case *net.DNSError:
 		if e.IsTemporary {
 			return true
