-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Comparing changes
Open a pull request
base repository: golang/net
base: v0.19.0
head repository: golang/net
compare: v0.20.0
- 16 commits
- 32 files changed
- 3 contributors
Commits on Nov 29, 2023
-
http2: explicitly set minimum TLS version in tests
Fixes tests when using 1.22 in certain cases where the go.mod 'go' directive is not being respected. Change-Id: Ia986a7c900287abd67f0a05f662906a665cdeb87 Reviewed-on: https://go-review.googlesource.com/c/net/+/546115 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Roland Shoemaker <[email protected]> Reviewed-by: Damien Neil <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f812076 - Browse repository at this point
Copy the full SHA f812076View commit details
Commits on Dec 5, 2023
-
For golang/go#58547 Change-Id: I601f1e74417c0de206f71da58cef5938bba6e860 Reviewed-on: https://go-review.googlesource.com/c/net/+/543084 Reviewed-by: Jonathan Amsterdam <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 491f354 - Browse repository at this point
Copy the full SHA 491f354View commit details -
quic: send occasional ack-eliciting packets
A receiver that is sending only non-ack-eliciting packets (for example, a connection reading data from a stream but not sending anything other than ACKs in response) can accumulate a large amount of state for in-flight, unacknowledged packets. Add an occasional PING frame when in this state, to cause the peer to send an ACK for our outstanding packets. Change-Id: Iaf6b5a9735fa356fdebaff24200420a280b0c9a5 Reviewed-on: https://go-review.googlesource.com/c/net/+/545215 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for c1b6eee - Browse repository at this point
Copy the full SHA c1b6eeeView commit details -
quic: unblock operations when closing conns
Blocking operations associated with a connection, such as accepting a stream or writing data to a stream, should be canceled when the connection is closed. Change-Id: I3b25789885a6c1a2b5aa2178a8d6219a8ea77cbb Reviewed-on: https://go-review.googlesource.com/c/net/+/545216 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]> Auto-Submit: Damien Neil <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for 08a78b1 - Browse repository at this point
Copy the full SHA 08a78b1View commit details
Commits on Dec 7, 2023
-
quic: avoid leaking tls goroutines in tests
Change-Id: Iaf273294ba3245bfeb387a72e068c048d0fcf93a Reviewed-on: https://go-review.googlesource.com/c/net/+/547736 Reviewed-by: Jonathan Amsterdam <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for 65efbad - Browse repository at this point
Copy the full SHA 65efbadView commit details
Commits on Dec 8, 2023
-
quic: skip leaked goroutine check on GOOS=js
Fixes golang/go#64620 Change-Id: I3b5ff4d1e1132a47b7cc7eb00861e9f7b76f8764 Reviewed-on: https://go-review.googlesource.com/c/net/+/548455 Auto-Submit: Damien Neil <[email protected]> Reviewed-by: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for 577e44a - Browse repository at this point
Copy the full SHA 577e44aView commit details
Commits on Dec 18, 2023
-
quic: fix data race in connection close
We were failing to hold streamsState.streamsMu when removing a closed stream from the conn's stream map. Rework this to remove the mutex entirely. The only access to the map that isn't on the conn's loop is during stream creation. Send a message to the loop to register the stream instead of using a mutex. Change-Id: I2e87089e87c61a6ade8219dfb8acec3809bf95de Reviewed-on: https://go-review.googlesource.com/c/net/+/545217 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for b952594 - Browse repository at this point
Copy the full SHA b952594View commit details -
quic: compute pnum len from max ack received, not sent
QUIC packet numbers are truncated to include only the least significant bits of the packet number. The number of bits which must be retained is computed based on the largest packet number known to have been received by the peer. See RFC 9000, section 17.1. We were incorrectly using the largest packet number we have received *from* the peer. Oops. (Test infrastructure change: Include the header byte in the testPacket structure, so we can see how many bytes the packet number was encoded with. Ignore this byte when comparing packets.) Change-Id: Iec17c69f007f8b39d14d24b0ca216c6a0018ae22 Reviewed-on: https://go-review.googlesource.com/c/net/+/545575 Reviewed-by: Jonathan Amsterdam <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for b0eb4d6 - Browse repository at this point
Copy the full SHA b0eb4d6View commit details -
quic/qlog: correctly write negative durations
"-10.000001", not "10.-000001". Change-Id: I84f6487bad15ab3a190e73e655236376b1781e85 Reviewed-on: https://go-review.googlesource.com/c/net/+/545576 Reviewed-by: Jonathan Amsterdam <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for 1e59a7e - Browse repository at this point
Copy the full SHA 1e59a7eView commit details -
quic/qlog: create log files with O_EXCL
Avoid confusing log corruption if two loggers try to write to the same file simultaneously. Change-Id: I3bfbcf56aa55c778ada0178d7c662c414878c9d1 Reviewed-on: https://go-review.googlesource.com/c/net/+/545577 Reviewed-by: Jonathan Amsterdam <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for 2b416c3 - Browse repository at this point
Copy the full SHA 2b416c3View commit details
Commits on Dec 19, 2023
-
quic: enable qlog output in tests
Set QLOG=/some/dir to enable qlog logging in tests. Change-Id: Id4006c66fd555ad0ca47914d0af9f9ab46467c9c Reviewed-on: https://go-review.googlesource.com/c/net/+/550796 Reviewed-by: Jonathan Amsterdam <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for c337daf - Browse repository at this point
Copy the full SHA c337dafView commit details -
The qlog schema puts packet sizes as part of a "raw" field of type RawInfo, not in the packet_sent/packet_received event. Move to the correct location. Change-Id: I4308d4bdb961cf83e29af014b60f50ed029cb915 Reviewed-on: https://go-review.googlesource.com/c/net/+/550797 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for f9726a9 - Browse repository at this point
Copy the full SHA f9726a9View commit details -
quic: avoid panic when PTO expires and implicitly-created streams exist
The streams map contains nil entries for implicitly-created streams. (Receiving a packet for stream N implicitly creates all streams of the same type <N.) We weren't checking for nil entries when iterating the map on PTO, resulting in a panic. Change the map value to be a wrapper type to make it more explicit that nil entries exist. Change-Id: I070c6d60631744018a6e6f2645c95a2f3d3d24b6 Reviewed-on: https://go-review.googlesource.com/c/net/+/550798 Reviewed-by: Jonathan Amsterdam <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for c136d0c - Browse repository at this point
Copy the full SHA c136d0cView commit details -
internal/quic/cmd/interop: use wget --no-verbose in Dockerfile
Pass --no-verbose to wget to avoid spamming the build logs with progress indicators. Change-Id: I36a0b91f8dac09cc4055c5d5db3fc61c9b269d6e Reviewed-on: https://go-review.googlesource.com/c/net/+/551495 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for f12db26 - Browse repository at this point
Copy the full SHA f12db26View commit details
Commits on Jan 4, 2024
-
quic: deflake TestStreamsCreateConcurrency
This test assumed that creating a stream and flushing it on the client ensured the server had accepted the stream. This isn't the case; the stream has been delivered to the server, but there's no guarantee that it been accepted by the user layer. Change the test to make a full loop: The client creates a stream, and then waits for the server to close it. Fixes golang/go#64788 Change-Id: I24f08502e9f5d8bd5a17e680b0aa19dcc2623841 Reviewed-on: https://go-review.googlesource.com/c/net/+/554175 Reviewed-by: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for 689bbc7 - Browse repository at this point
Copy the full SHA 689bbc7View commit details
Commits on Jan 8, 2024
-
go.mod: update golang.org/x dependencies
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I77f3c5560bd989f4e9c6b8c3f36e900fefe9bb0e Reviewed-on: https://go-review.googlesource.com/c/net/+/554675 Reviewed-by: Than McIntosh <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Gopher Robot <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for cb5b10f - Browse repository at this point
Copy the full SHA cb5b10fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.19.0...v0.20.0