Skip to content

Problem with pre-receive hook if there is whitespace character in file/folder name  #362

Open
@windwalker78

Description

@windwalker78

Hello,

This is a suggestion for a change in: "pre-receive-hooks/block_file_extensions.sh". When you try to push an blob object, which has whitespace in its name, the current loop will break. My suggestion is to transform:

    for FILE  in `git log -1 --name-only --pretty=format:'' $COMMIT`;
    do
      case $FILE in
      *.zip|*.gz|*.tgz )
        echo "Hello there! We have restricted committing that filetype. Please see Dave in IT to discuss alternatives."
        exit 1
        ;;
      esac
    done

into:

      while IFS= read -r FILE; do
        case "$FILE" in
          *.zip|*.gz|*.tgz )
          echo "Hello there! We have restricted committing that filetype. Please see Dave in IT to discuss alternatives."
          exit 1
        esac
      done <<< "$(git log -1 --name-only --pretty=format:'' $COMMIT)"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions