feat: allow email updates in user resources

ethanndickson · ethanndickson · commit 4813553a1d0a · 2024-07-16T06:37:30.000Z
diff --git a/internal/provider/user_resource.go b/internal/provider/user_resource.go
@@ -81,6 +81,9 @@ func (r *UserResource) Schema(ctx context.Context, req resource.SchemaRequest, r
 			"email": schema.StringAttribute{
 				MarkdownDescription: "Email address of the user.",
 				Required:            true,
+				PlanModifiers: []planmodifier.String{
+					stringplanmodifier.RequiresReplace(),
+				},
 			},
 			"roles": schema.SetAttribute{
 				MarkdownDescription: "Roles assigned to the user. Valid roles are 'owner', 'template-admin', 'user-admin', and 'auditor'.",
diff --git a/internal/provider/user_resource_test.go b/internal/provider/user_resource_test.go
@@ -10,6 +10,7 @@ import (
 
 	"github.com/coder/terraform-provider-coderd/integration"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-plugin-testing/terraform"
 	"github.com/stretchr/testify/require"
 )
 
@@ -35,6 +36,10 @@ func TestAccUserResource(t *testing.T) {
 	cfg2.Username = PtrTo("exampleNew")
 	cfg2.Name = PtrTo("Example User New")
 
+	cfg3 := cfg1
+	cfg3.Email = PtrTo("example2@coder.com")
+
+	var userId string
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
 		ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
@@ -68,6 +73,15 @@ func TestAccUserResource(t *testing.T) {
 				Check: resource.ComposeAggregateTestCheckFunc(
 					resource.TestCheckResourceAttr("coderd_user.test", "username", "exampleNew"),
 					resource.TestCheckResourceAttr("coderd_user.test", "name", "Example User New"),
+					testAccIdChanged("coderd_user.test", &userId),
+				),
+			},
+			// Replace testing
+			{
+				Config: cfg3.String(t),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr("coderd_user.test", "email", "example2@coder.com"),
+					testAccIdChanged("coderd_user.test", &userId),
 				),
 			},
 			// Delete testing automatically occurs in TestCase
@@ -151,3 +165,24 @@ resource "coderd_user" "test" {
 
 	return buf.String()
 }
+
+// Check if the id has changed since the last time this check function was run.
+func testAccIdChanged(resourceName string, id *string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		rs, ok := s.RootModule().Resources[resourceName]
+		if !ok {
+			return fmt.Errorf("Resource %s not found", resourceName)
+		}
+		if rs.Primary.ID == "" {
+			return fmt.Errorf("No ID is set")
+		}
+		if *id == "" {
+			*id = rs.Primary.ID
+			return nil
+		}
+		if rs.Primary.ID == *id {
+			return fmt.Errorf("ID did not change from %s", rs.Primary.ID)
+		}
+		return nil
+	}
+}
