Skip to content

Commit dbfbef6

Browse files
authored
chore(cli): increase reconciliation interval to 1 minute (#18690)
Increase prebuilds reconciliation and backoff interval to 1 minute by default.
1 parent 57a6d59 commit dbfbef6

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

cli/testdata/coder_server_--help.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,7 @@ workspaces stopping during the day due to template scheduling.
680680
WORKSPACE PREBUILDS OPTIONS:
681681
Configure how workspace prebuilds behave.
682682

683-
--workspace-prebuilds-reconciliation-interval duration, $CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL (default: 15s)
683+
--workspace-prebuilds-reconciliation-interval duration, $CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL (default: 1m0s)
684684
How often to reconcile workspace prebuilds state.
685685

686686
⚠️ DANGEROUS OPTIONS:

cli/testdata/server-config.yaml.golden

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -698,12 +698,12 @@ notifications:
698698
# Configure how workspace prebuilds behave.
699699
workspace_prebuilds:
700700
# How often to reconcile workspace prebuilds state.
701-
# (default: 15s, type: duration)
702-
reconciliation_interval: 15s
701+
# (default: 1m0s, type: duration)
702+
reconciliation_interval: 1m0s
703703
# Interval to increase reconciliation backoff by when prebuilds fail, after which
704704
# a retry attempt is made.
705-
# (default: 15s, type: duration)
706-
reconciliation_backoff_interval: 15s
705+
# (default: 1m0s, type: duration)
706+
reconciliation_backoff_interval: 1m0s
707707
# Interval to look back to determine number of failed prebuilds, which influences
708708
# backoff.
709709
# (default: 1h0m0s, type: duration)

codersdk/deployment.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3066,7 +3066,7 @@ Write out the current server config as YAML to stdout.`,
30663066
Flag: "workspace-prebuilds-reconciliation-interval",
30673067
Env: "CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL",
30683068
Value: &c.Prebuilds.ReconciliationInterval,
3069-
Default: (time.Second * 15).String(),
3069+
Default: time.Minute.String(),
30703070
Group: &deploymentGroupPrebuilds,
30713071
YAML: "reconciliation_interval",
30723072
Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"),
@@ -3077,7 +3077,7 @@ Write out the current server config as YAML to stdout.`,
30773077
Flag: "workspace-prebuilds-reconciliation-backoff-interval",
30783078
Env: "CODER_WORKSPACE_PREBUILDS_RECONCILIATION_BACKOFF_INTERVAL",
30793079
Value: &c.Prebuilds.ReconciliationBackoffInterval,
3080-
Default: (time.Second * 15).String(),
3080+
Default: time.Minute.String(),
30813081
Group: &deploymentGroupPrebuilds,
30823082
YAML: "reconciliation_backoff_interval",
30833083
Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"),

docs/reference/cli/server.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

enterprise/cli/testdata/coder_server_--help.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ workspaces stopping during the day due to template scheduling.
681681
WORKSPACE PREBUILDS OPTIONS:
682682
Configure how workspace prebuilds behave.
683683

684-
--workspace-prebuilds-reconciliation-interval duration, $CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL (default: 15s)
684+
--workspace-prebuilds-reconciliation-interval duration, $CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL (default: 1m0s)
685685
How often to reconcile workspace prebuilds state.
686686

687687
⚠️ DANGEROUS OPTIONS:

0 commit comments

Comments
 (0)