fix dbmem tests

evgeniy-scherbina · evgeniy-scherbina · commit a3fd79517ff8 · 2025-07-07T21:02:22.000Z
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
@@ -1845,7 +1845,7 @@ func (s *MethodTestSuite) TestUser() {
 		check.Args(database.DeleteCustomRoleParams{
 			Name: customRole.Name,
 		}).Asserts(
-		// fails immediately, missing organization id
+			// fails immediately, missing organization id
 		).Errors(dbauthz.NotAuthorizedError{Err: xerrors.New("custom roles must belong to an organization")})
 	}))
 	s.Run("Blank/UpdateCustomRole", s.Subtest(func(db database.Store, check *expects) {
@@ -1876,7 +1876,7 @@ func (s *MethodTestSuite) TestUser() {
 				codersdk.ResourceWorkspace: {codersdk.ActionRead},
 			}), convertSDKPerm),
 		}).Asserts(
-		// fails immediately, missing organization id
+			// fails immediately, missing organization id
 		).Errors(dbauthz.NotAuthorizedError{Err: xerrors.New("custom roles must belong to an organization")})
 	}))
 	s.Run("OrgPermissions/UpdateCustomRole", s.Subtest(func(db database.Store, check *expects) {
@@ -1929,7 +1929,7 @@ func (s *MethodTestSuite) TestUser() {
 				codersdk.ResourceWorkspace: {codersdk.ActionRead},
 			}), convertSDKPerm),
 		}).Asserts(
-		// fails immediately, missing organization id
+			// fails immediately, missing organization id
 		).Errors(dbauthz.NotAuthorizedError{Err: xerrors.New("custom roles must belong to an organization")})
 	}))
 	s.Run("OrgPermissions/InsertCustomRole", s.Subtest(func(db database.Store, check *expects) {
@@ -4262,13 +4262,13 @@ func (s *MethodTestSuite) TestSystemFunctions() {
 			StorageMethod: database.ProvisionerStorageMethodFile,
 			Type:          database.ProvisionerJobTypeWorkspaceBuild,
 			Input:         json.RawMessage("{}"),
-		}).Asserts( /* rbac.ResourceProvisionerJobs, policy.ActionCreate */ )
+		}).Asserts( /* rbac.ResourceProvisionerJobs, policy.ActionCreate */)
 	}))
 	s.Run("InsertProvisionerJobLogs", s.Subtest(func(db database.Store, check *expects) {
 		j := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{})
 		check.Args(database.InsertProvisionerJobLogsParams{
 			JobID: j.ID,
-		}).Asserts( /* rbac.ResourceProvisionerJobs, policy.ActionUpdate */ )
+		}).Asserts( /* rbac.ResourceProvisionerJobs, policy.ActionUpdate */)
 	}))
 	s.Run("InsertProvisionerJobTimings", s.Subtest(func(db database.Store, check *expects) {
 		j := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{})
@@ -5725,6 +5725,8 @@ func (s *MethodTestSuite) TestUserSecrets() {
 		arg := database.InsertUserSecretParams{
 			UserID: user.ID,
 		}
-		check.Args(arg).Asserts(rbac.ResourceUserSecret.WithOwner(arg.UserID.String()), policy.ActionCreate)
+		check.Args(arg).
+			Asserts(rbac.ResourceUserSecret.WithOwner(arg.UserID.String()), policy.ActionCreate).
+			ErrorsWithInMemDB(dbmem.ErrUnimplemented)
 	}))
 }
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -9716,7 +9716,7 @@ func (q *FakeQuerier) InsertUserSecret(ctx context.Context, arg database.InsertU
 		return database.UserSecret{}, err
 	}
 
-	panic("not implemented")
+	return database.UserSecret{}, ErrUnimplemented
 }
 
 func (q *FakeQuerier) InsertVolumeResourceMonitor(_ context.Context, arg database.InsertVolumeResourceMonitorParams) (database.WorkspaceAgentVolumeResourceMonitor, error) {

Original file line number	Diff line number	Diff line change
`@@ -9716,7 +9716,7 @@ func (q *FakeQuerier) InsertUserSecret(ctx context.Context, arg database.InsertU`
`9716`	`9716`	`return database.UserSecret{}, err`
`9717`	`9717`	`}`
`9718`	`9718`
`9719`		`- panic("not implemented")`
	`9719`	`+ return database.UserSecret{}, ErrUnimplemented`
`9720`	`9720`	`}`
`9721`	`9721`
`9722`	`9722`	`func (q *FakeQuerier) InsertVolumeResourceMonitor(_ context.Context, arg database.InsertVolumeResourceMonitorParams) (database.WorkspaceAgentVolumeResourceMonitor, error) {`