Skip to content

Commit

Permalink
Remove impossible TODO
Browse files Browse the repository at this point in the history
JsReplace() cannot be used, since more than 9 placeholders would
be needed. JsReplace only supports $1 to $9.

Change-Id: Ie3d8319944916f72342d2c6cd2614954a683387f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780198
Reviewed-by: Maks Orlovich <[email protected]>
Commit-Queue: Caleb Raitto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1184194}
  • Loading branch information
caraitto authored and Chromium LUCI CQ committed Aug 16, 2023
1 parent 698bbb3 commit 2126493
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion content/browser/interest_group/auction_runner_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ std::string MakeBidScript(const url::Origin& seller,
const std::string& debug_loss_report_url = "",
const std::string& debug_win_report_url = "",
bool report_reject_reason = false) {
// TODO(morlovich): Use JsReplace.
constexpr char kBidScript[] = R"(
const seller = "%s";
const bid = %s;
Expand Down

0 comments on commit 2126493

Please sign in to comment.