Skip to content

Commit 4546e05

Browse files
connorjclarkconnorjclark
authored
report: consolidate table headers (#14315)
1 parent 4b8348f commit 4546e05

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+1103
-1111
lines changed

‎core/audits/accessibility/axe-audit.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ class AxeAudit extends Audit {
8888
/** @type {LH.Audit.Details.Table['headings']} */
8989
const headings = [
9090
/* eslint-disable max-len */
91-
{key: 'node', itemType: 'node', subItemsHeading: {key: 'relatedNode', itemType: 'node'}, text: str_(UIStrings.failingElementsHeader)},
91+
{key: 'node', valueType: 'node', subItemsHeading: {key: 'relatedNode', valueType: 'node'}, label: str_(UIStrings.failingElementsHeader)},
9292
/* eslint-enable max-len */
9393
];
9494

‎core/audits/autocomplete.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,9 @@ class AutocompleteAudit extends Audit {
266266

267267
/** @type {LH.Audit.Details.Table['headings']} */
268268
const headings = [
269-
{key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnFailingElem)},
270-
{key: 'current', itemType: 'text', text: str_(UIStrings.columnCurrent)},
271-
{key: 'suggestion', itemType: 'text', text: str_(UIStrings.columnSuggestions)},
269+
{key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnFailingElem)},
270+
{key: 'current', valueType: 'text', label: str_(UIStrings.columnCurrent)},
271+
{key: 'suggestion', valueType: 'text', label: str_(UIStrings.columnSuggestions)},
272272
];
273273
const details = Audit.makeTableDetails(headings, failingFormsData);
274274
let displayValue;

‎core/audits/bootup-time.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,11 @@ class BootupTime extends Audit {
121121

122122
/** @type {LH.Audit.Details.Table['headings']} */
123123
const headings = [
124-
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
125-
{key: 'total', granularity: 1, itemType: 'ms', text: str_(UIStrings.columnTotal)},
126-
{key: 'scripting', granularity: 1, itemType: 'ms', text: str_(UIStrings.columnScriptEval)},
127-
{key: 'scriptParseCompile', granularity: 1, itemType: 'ms',
128-
text: str_(UIStrings.columnScriptParse)},
124+
{key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
125+
{key: 'total', granularity: 1, valueType: 'ms', label: str_(UIStrings.columnTotal)},
126+
{key: 'scripting', granularity: 1, valueType: 'ms', label: str_(UIStrings.columnScriptEval)},
127+
{key: 'scriptParseCompile', granularity: 1, valueType: 'ms',
128+
label: str_(UIStrings.columnScriptParse)},
129129
];
130130

131131
const details = BootupTime.makeTableDetails(headings, results, summary);

‎core/audits/byte-efficiency/duplicated-javascript.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ class DuplicatedJavascript extends ByteEfficiencyAudit {
225225
});
226226
}
227227

228-
/** @type {LH.Audit.Details.OpportunityColumnHeading[]} */
228+
/** @type {LH.Audit.Details.TableColumnHeading[]} */
229229
const headings = [
230230
/* eslint-disable max-len */
231231
{key: 'source', valueType: 'code', subItemsHeading: {key: 'url', valueType: 'url'}, label: str_(i18n.UIStrings.columnSource)},

‎core/audits/byte-efficiency/legacy-javascript.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ class LegacyJavascript extends ByteEfficiencyAudit {
455455
}
456456
}
457457

458-
/** @type {LH.Audit.Details.OpportunityColumnHeading[]} */
458+
/** @type {LH.Audit.Details.TableColumnHeading[]} */
459459
const headings = [
460460
/* eslint-disable max-len */
461461
{key: 'url', valueType: 'url', subItemsHeading: {key: 'location', valueType: 'source-location'}, label: str_(i18n.UIStrings.columnURL)},

‎core/audits/byte-efficiency/total-byte-weight.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ class TotalByteWeight extends Audit {
8989

9090
/** @type {LH.Audit.Details.Table['headings']} */
9191
const headings = [
92-
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
93-
{key: 'totalBytes', itemType: 'bytes', text: str_(i18n.UIStrings.columnTransferSize)},
92+
{key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
93+
{key: 'totalBytes', valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize)},
9494
];
9595

9696
const tableDetails = Audit.makeTableDetails(headings, results);

‎core/audits/byte-efficiency/uses-long-cache-ttl.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -272,11 +272,11 @@ class CacheHeaders extends Audit {
272272

273273
/** @type {LH.Audit.Details.Table['headings']} */
274274
const headings = [
275-
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
275+
{key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
276276
// TODO(i18n): pre-compute localized duration
277-
{key: 'cacheLifetimeMs', itemType: 'ms', text: str_(i18n.UIStrings.columnCacheTTL),
277+
{key: 'cacheLifetimeMs', valueType: 'ms', label: str_(i18n.UIStrings.columnCacheTTL),
278278
displayUnit: 'duration'},
279-
{key: 'totalBytes', itemType: 'bytes', text: str_(i18n.UIStrings.columnTransferSize),
279+
{key: 'totalBytes', valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize),
280280
displayUnit: 'kb', granularity: 1},
281281
];
282282

‎core/audits/byte-efficiency/uses-responsive-images-snapshot.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,10 @@ class UsesResponsiveImagesSnapshot extends Audit {
8080
/** @type {LH.Audit.Details.Table['headings']} */
8181
const headings = [
8282
/* eslint-disable max-len */
83-
{key: 'node', itemType: 'node', text: ''},
84-
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
85-
{key: 'displayedDimensions', itemType: 'text', text: str_(UIStrings.columnDisplayedDimensions)},
86-
{key: 'actualDimensions', itemType: 'text', text: str_(UIStrings.columnActualDimensions)},
83+
{key: 'node', valueType: 'node', label: ''},
84+
{key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
85+
{key: 'displayedDimensions', valueType: 'text', label: str_(UIStrings.columnDisplayedDimensions)},
86+
{key: 'actualDimensions', valueType: 'text', label: str_(UIStrings.columnActualDimensions)},
8787
/* eslint-enable max-len */
8888
];
8989

‎core/audits/csp-xss.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,9 @@ class CspXss extends Audit {
163163
/** @type {LH.Audit.Details.Table['headings']} */
164164
const headings = [
165165
/* eslint-disable max-len */
166-
{key: 'description', itemType: 'text', subItemsHeading: {key: 'description'}, text: str_(i18n.UIStrings.columnDescription)},
167-
{key: 'directive', itemType: 'code', subItemsHeading: {key: 'directive'}, text: str_(UIStrings.columnDirective)},
168-
{key: 'severity', itemType: 'text', subItemsHeading: {key: 'severity'}, text: str_(UIStrings.columnSeverity)},
166+
{key: 'description', valueType: 'text', subItemsHeading: {key: 'description'}, label: str_(i18n.UIStrings.columnDescription)},
167+
{key: 'directive', valueType: 'code', subItemsHeading: {key: 'directive'}, label: str_(UIStrings.columnDirective)},
168+
{key: 'severity', valueType: 'text', subItemsHeading: {key: 'severity'}, label: str_(UIStrings.columnSeverity)},
169169
/* eslint-enable max-len */
170170
];
171171
const details = Audit.makeTableDetails(headings, results);

‎core/audits/deprecations.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ class Deprecations extends Audit {
9292

9393
/** @type {LH.Audit.Details.Table['headings']} */
9494
const headings = [
95-
{key: 'value', itemType: 'text', text: str_(UIStrings.columnDeprecate)},
96-
{key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
95+
{key: 'value', valueType: 'text', label: str_(UIStrings.columnDeprecate)},
96+
{key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
9797
];
9898
const details = Audit.makeTableDetails(headings, deprecations);
9999

‎core/audits/dobetterweb/dom-size.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ class DOMSize extends Audit {
8585

8686
/** @type {LH.Audit.Details.Table['headings']} */
8787
const headings = [
88-
{key: 'statistic', itemType: 'text', text: str_(UIStrings.columnStatistic)},
89-
{key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnElement)},
90-
{key: 'value', itemType: 'numeric', text: str_(UIStrings.columnValue)},
88+
{key: 'statistic', valueType: 'text', label: str_(UIStrings.columnStatistic)},
89+
{key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
90+
{key: 'value', valueType: 'numeric', label: str_(UIStrings.columnValue)},
9191
];
9292

9393
/** @type {LH.Audit.Details.Table['items']} */

‎core/audits/dobetterweb/geolocation-on-start.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class GeolocationOnStart extends ViolationAudit {
5252

5353
/** @type {LH.Audit.Details.Table['headings']} */
5454
const headings = [
55-
{key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
55+
{key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
5656
];
5757
// TODO(bckenny): there should actually be a ts error here. results[0].stackTrace
5858
// should violate the results type. Shouldn't be removed from details items regardless.

‎core/audits/dobetterweb/inspector-issues.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ class IssuesPanelEntries extends Audit {
152152
/** @type {LH.Audit.Details.Table['headings']} */
153153
const headings = [
154154
/* eslint-disable max-len */
155-
{key: 'issueType', itemType: 'text', subItemsHeading: {key: 'url', itemType: 'url'}, text: str_(UIStrings.columnIssueType)},
155+
{key: 'issueType', valueType: 'text', subItemsHeading: {key: 'url', valueType: 'url'}, label: str_(UIStrings.columnIssueType)},
156156
/* eslint-enable max-len */
157157
];
158158

‎core/audits/dobetterweb/js-libraries.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ class JsLibrariesAudit extends Audit {
5454

5555
/** @type {LH.Audit.Details.Table['headings']} */
5656
const headings = [
57-
{key: 'name', itemType: 'text', text: str_(i18n.UIStrings.columnName)},
58-
{key: 'version', itemType: 'text', text: str_(UIStrings.columnVersion)},
57+
{key: 'name', valueType: 'text', label: str_(i18n.UIStrings.columnName)},
58+
{key: 'version', valueType: 'text', label: str_(UIStrings.columnVersion)},
5959
];
6060
const details = Audit.makeTableDetails(headings, libDetails, {});
6161

‎core/audits/dobetterweb/no-document-write.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class NoDocWriteAudit extends ViolationAudit {
6868

6969
/** @type {LH.Audit.Details.Table['headings']} */
7070
const headings = [
71-
{key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
71+
{key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
7272
];
7373
// TODO(bckenny): see TODO in geolocation-on-start
7474
const details = ViolationAudit.makeTableDetails(headings, results);

‎core/audits/dobetterweb/notification-on-start.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class NotificationOnStart extends ViolationAudit {
5252

5353
/** @type {LH.Audit.Details.Table['headings']} */
5454
const headings = [
55-
{key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
55+
{key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
5656
];
5757
// TODO(bckenny): see TODO in geolocation-on-start
5858
const details = ViolationAudit.makeTableDetails(headings, results);

‎core/audits/dobetterweb/password-inputs-can-be-pasted-into.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class PasswordInputsCanBePastedIntoAudit extends Audit {
5151

5252
/** @type {LH.Audit.Details.Table['headings']} */
5353
const headings = [
54-
{key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnFailingElem)},
54+
{key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnFailingElem)},
5555
];
5656

5757
return {

‎core/audits/dobetterweb/uses-http2.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,8 @@ class UsesHTTP2Audit extends Audit {
214214
if (artifacts.GatherContext.gatherMode === 'timespan') {
215215
/** @type {LH.Audit.Details.Table['headings']} */
216216
const headings = [
217-
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
218-
{key: 'protocol', itemType: 'text', text: str_(UIStrings.columnProtocol)},
217+
{key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
218+
{key: 'protocol', valueType: 'text', label: str_(UIStrings.columnProtocol)},
219219
];
220220

221221
const details = Audit.makeTableDetails(headings, resources);

‎core/audits/dobetterweb/uses-passive-event-listeners.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class PassiveEventsAudit extends ViolationAudit {
5151

5252
/** @type {LH.Audit.Details.Table['headings']} */
5353
const headings = [
54-
{key: 'source', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
54+
{key: 'source', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
5555
];
5656
// TODO(bckenny): see TODO in geolocation-on-start
5757
const details = ViolationAudit.makeTableDetails(headings, results);

‎core/audits/errors-in-console.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,10 @@ class ErrorLogs extends Audit {
100100

101101
/** @type {LH.Audit.Details.Table['headings']} */
102102
const headings = [
103-
{key: 'sourceLocation', itemType: 'source-location', text: str_(i18n.UIStrings.columnSource)},
104-
{key: 'description', itemType: 'code', text: str_(i18n.UIStrings.columnDescription)},
103+
/* eslint-disable max-len */
104+
{key: 'sourceLocation', valueType: 'source-location', label: str_(i18n.UIStrings.columnSource)},
105+
{key: 'description', valueType: 'code', label: str_(i18n.UIStrings.columnDescription)},
106+
/* eslint-enable max-len */
105107
];
106108

107109
const details = Audit.makeTableDetails(headings, tableRows);

‎core/audits/font-display.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ class FontDisplay extends Audit {
175175

176176
/** @type {LH.Audit.Details.Table['headings']} */
177177
const headings = [
178-
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
179-
{key: 'wastedMs', itemType: 'ms', text: str_(i18n.UIStrings.columnWastedMs)},
178+
{key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
179+
{key: 'wastedMs', valueType: 'ms', label: str_(i18n.UIStrings.columnWastedMs)},
180180
];
181181

182182
const details = Audit.makeTableDetails(headings, results);

‎core/audits/image-aspect-ratio.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ class ImageAspectRatio extends Audit {
105105

106106
/** @type {LH.Audit.Details.Table['headings']} */
107107
const headings = [
108-
{key: 'node', itemType: 'node', text: ''},
109-
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
110-
{key: 'displayedAspectRatio', itemType: 'text', text: str_(UIStrings.columnDisplayed)},
111-
{key: 'actualAspectRatio', itemType: 'text', text: str_(UIStrings.columnActual)},
108+
{key: 'node', valueType: 'node', label: ''},
109+
{key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
110+
{key: 'displayedAspectRatio', valueType: 'text', label: str_(UIStrings.columnDisplayed)},
111+
{key: 'actualAspectRatio', valueType: 'text', label: str_(UIStrings.columnActual)},
112112
];
113113

114114
return {

‎core/audits/image-size-responsive.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -264,11 +264,11 @@ class ImageSizeResponsive extends Audit {
264264

265265
/** @type {LH.Audit.Details.Table['headings']} */
266266
const headings = [
267-
{key: 'node', itemType: 'node', text: ''},
268-
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
269-
{key: 'displayedSize', itemType: 'text', text: str_(UIStrings.columnDisplayed)},
270-
{key: 'actualSize', itemType: 'text', text: str_(UIStrings.columnActual)},
271-
{key: 'expectedSize', itemType: 'text', text: str_(UIStrings.columnExpected)},
267+
{key: 'node', valueType: 'node', label: ''},
268+
{key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
269+
{key: 'displayedSize', valueType: 'text', label: str_(UIStrings.columnDisplayed)},
270+
{key: 'actualSize', valueType: 'text', label: str_(UIStrings.columnActual)},
271+
{key: 'expectedSize', valueType: 'text', label: str_(UIStrings.columnExpected)},
272272
];
273273

274274
const finalResults = sortResultsBySizeDelta(deduplicateResultsByUrl(results));

‎core/audits/installable-manifest.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ class InstallableManifest extends Audit {
216216

217217
/** @type {LH.Audit.Details.Table['headings']} */
218218
const headings = [
219-
{key: 'reason', itemType: 'text', text: str_(UIStrings.columnValue)},
219+
{key: 'reason', valueType: 'text', label: str_(UIStrings.columnValue)},
220220
];
221221

222222
// Errors for report table.

‎core/audits/is-on-https.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ class HTTPS extends Audit {
8282

8383
/** @type {LH.Audit.Details.Table['headings']} */
8484
const headings = [
85-
{key: 'url', itemType: 'url', text: str_(UIStrings.columnInsecureURL)},
86-
{key: 'resolution', itemType: 'text', text: str_(UIStrings.columnResolution)},
85+
{key: 'url', valueType: 'url', label: str_(UIStrings.columnInsecureURL)},
86+
{key: 'resolution', valueType: 'text', label: str_(UIStrings.columnResolution)},
8787
];
8888

8989
for (const details of artifacts.InspectorIssues.mixedContentIssue) {

‎core/audits/largest-contentful-paint-element.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class LargestContentfulPaintElement extends Audit {
4848

4949
/** @type {LH.Audit.Details.Table['headings']} */
5050
const headings = [
51-
{key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnElement)},
51+
{key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
5252
];
5353

5454
const details = Audit.makeTableDetails(headings, lcpElementDetails);

‎core/audits/layout-shift-elements.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ class LayoutShiftElements extends Audit {
4949

5050
/** @type {LH.Audit.Details.Table['headings']} */
5151
const headings = [
52-
{key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnElement)},
53-
{key: 'score', itemType: 'numeric',
54-
granularity: 0.001, text: str_(UIStrings.columnContribution)},
52+
{key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
53+
{key: 'score', valueType: 'numeric',
54+
granularity: 0.001, label: str_(UIStrings.columnContribution)},
5555
];
5656

5757
const details = Audit.makeTableDetails(headings, clsElementData);

‎core/audits/lcp-lazy-loaded.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class LargestContentfulPaintLazyLoaded extends Audit {
6464

6565
/** @type {LH.Audit.Details.Table['headings']} */
6666
const headings = [
67-
{key: 'node', itemType: 'node', text: str_(i18n.UIStrings.columnElement)},
67+
{key: 'node', valueType: 'node', label: str_(i18n.UIStrings.columnElement)},
6868
];
6969

7070
const details = Audit.makeTableDetails(headings, [

‎core/audits/long-tasks.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,9 @@ class LongTasks extends Audit {
9898
/** @type {LH.Audit.Details.Table['headings']} */
9999
const headings = [
100100
/* eslint-disable max-len */
101-
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
102-
{key: 'startTime', itemType: 'ms', granularity: 1, text: str_(i18n.UIStrings.columnStartTime)},
103-
{key: 'duration', itemType: 'ms', granularity: 1, text: str_(i18n.UIStrings.columnDuration)},
101+
{key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
102+
{key: 'startTime', valueType: 'ms', granularity: 1, label: str_(i18n.UIStrings.columnStartTime)},
103+
{key: 'duration', valueType: 'ms', granularity: 1, label: str_(i18n.UIStrings.columnDuration)},
104104
/* eslint-enable max-len */
105105
];
106106

‎core/audits/main-thread-tasks.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ class MainThreadTasks extends Audit {
4242

4343
/** @type {LH.Audit.Details.Table['headings']} */
4444
const headings = [
45-
{key: 'startTime', itemType: 'ms', granularity: 1, text: 'Start Time'},
46-
{key: 'duration', itemType: 'ms', granularity: 1, text: 'End Time'},
45+
{key: 'startTime', valueType: 'ms', granularity: 1, label: 'Start Time'},
46+
{key: 'duration', valueType: 'ms', granularity: 1, label: 'End Time'},
4747
];
4848

4949
const tableDetails = Audit.makeTableDetails(headings, results);

‎core/audits/mainthread-work-breakdown.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,10 @@ class MainThreadWorkBreakdown extends Audit {
107107

108108
/** @type {LH.Audit.Details.Table['headings']} */
109109
const headings = [
110-
{key: 'groupLabel', itemType: 'text', text: str_(UIStrings.columnCategory)},
111-
{key: 'duration', itemType: 'ms', granularity: 1, text: str_(i18n.UIStrings.columnTimeSpent)},
110+
/* eslint-disable max-len */
111+
{key: 'groupLabel', valueType: 'text', label: str_(UIStrings.columnCategory)},
112+
{key: 'duration', valueType: 'ms', granularity: 1, label: str_(i18n.UIStrings.columnTimeSpent)},
113+
/* eslint-enable max-len */
112114
];
113115

114116
results.sort((a, b) => categoryTotals[b.group] - categoryTotals[a.group]);

0 commit comments

Comments
 (0)