[lighthouse] Make Moto G Power the emulated mobile device

adamraine · Devtools-frontend LUCI CQ · commit 142747677795 · 2023-02-03T20:06:39.000Z
This should accompany the release of Lighthouse 10.0 which switches the default mobile device to the Moto G power. Lighthouse PR: GoogleChrome/lighthouse#14674 Bug: None Change-Id: I84154e10181d9c02e32daa70893b7ff4ce5905aa Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4219345 Reviewed-by: Connor Clark <cjamcl@chromium.org> Commit-Queue: Connor Clark <cjamcl@chromium.org>
diff --git a/front_end/panels/lighthouse/LighthousePanel.ts b/front_end/panels/lighthouse/LighthousePanel.ts
@@ -466,7 +466,7 @@ export class LighthousePanel extends UI.Panel.Panel {
       emulationModel.deviceOutlineSetting().set(true);
 
       for (const device of EmulationModel.EmulatedDevices.EmulatedDevicesList.instance().standard()) {
-        if (device.title === 'Moto G4') {
+        if (device.title === 'Moto G Power') {
           emulationModel.emulate(EmulationModel.DeviceModeModel.Type.Device, device, device.modes[0], 1);
         }
       }
diff --git a/test/e2e/lighthouse/devtools-settings_test.ts b/test/e2e/lighthouse/devtools-settings_test.ts
@@ -105,11 +105,11 @@ describe('DevTools', function() {
 
       const {artifacts} = await waitForResult();
       assert.deepStrictEqual(artifacts.ViewportDimensions, {
-        innerHeight: 640,
-        innerWidth: 360,
-        outerHeight: 640,
-        outerWidth: 360,
-        devicePixelRatio: 3,
+        innerHeight: 823,
+        innerWidth: 412,
+        outerHeight: 823,
+        outerWidth: 412,
+        devicePixelRatio: 1.75,
       });
 
       const zoomText = await zoomButton.evaluate(zoomButtonEl => zoomButtonEl.textContent);
diff --git a/test/e2e/lighthouse/navigation_test.ts b/test/e2e/lighthouse/navigation_test.ts
@@ -107,11 +107,11 @@ describe('Navigation', async function() {
         }
 
         assert.deepStrictEqual(artifacts.ViewportDimensions, {
-          innerHeight: 640,
-          innerWidth: 360,
-          outerHeight: 640,
-          outerWidth: 360,
-          devicePixelRatio: 3,
+          innerHeight: 823,
+          innerWidth: 412,
+          outerHeight: 823,
+          outerWidth: 412,
+          devicePixelRatio: 1.75,
         });
 
         const {auditResults, erroredAudits, failedAudits} = getAuditsBreakdown(lhr);
diff --git a/test/e2e/lighthouse/snapshot_test.ts b/test/e2e/lighthouse/snapshot_test.ts
@@ -66,11 +66,11 @@ describe('Snapshot', async function() {
     assert.strictEqual(lhr.gatherMode, 'snapshot');
 
     assert.deepStrictEqual(artifacts.ViewportDimensions, {
-      innerHeight: 640,
-      innerWidth: 360,
-      outerHeight: 640,
-      outerWidth: 360,
-      devicePixelRatio: 3,
+      innerHeight: 823,
+      innerWidth: 412,
+      outerHeight: 823,
+      outerWidth: 412,
+      devicePixelRatio: 1.75,
     });
 
     const {auditResults, erroredAudits, failedAudits} = getAuditsBreakdown(lhr);

Original file line number	Diff line number	Diff line change
`@@ -466,7 +466,7 @@ export class LighthousePanel extends UI.Panel.Panel {`
`466`	`466`	`emulationModel.deviceOutlineSetting().set(true);`
`467`	`467`
`468`	`468`	`for (const device of EmulationModel.EmulatedDevices.EmulatedDevicesList.instance().standard()) {`
`469`		`- if (device.title === 'Moto G4') {`
	`469`	`+ if (device.title === 'Moto G Power') {`
`470`	`470`	`emulationModel.emulate(EmulationModel.DeviceModeModel.Type.Device, device, device.modes[0], 1);`
`471`	`471`	`}`
`472`	`472`	`}`