Honza Bambas (:mayhemer) Reporter
	Description • 12 years ago

http://hg.mozilla.org/mozilla-central/annotate/8776d96f0099/image/src/imgLoader.cpp#l1360

The code already has several mistakes and has never actually worked.

  if ((appCacheContainer = do_GetInterface(request->mRequest)))

- request->mRequest is null at this time
- we have to QI on it

    appCacheContainer->GetApplicationCache(getter_AddRefs(requestAppCache));
  if ((appCacheContainer = do_QueryInterface(aLoadGroup)))

- here we have to do GI instead

    appCacheContainer->GetApplicationCache(getter_AddRefs(groupAppCache));


In bug 734062 I'm adding a more sophisticated check that will bypass cached images for any difference in reference to app caches by the original load and any new load.