Closed Bug 612625 Opened 14 years ago Closed 14 years ago

intermittent orange: test_bug607584.xul continues executing after we've left the page, mostly showing up in test_bug171813.html

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b8

People

(Reporter: dbaron, Assigned: ehsan.akhgari)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Patch (v1)
2.12 KB, patch
roc
: review+
Details | Diff | Splinter Review 
There have been a number of JS errors happening during the execution of other test in which we're trying to execute code from test_bug607584.xul.  These have been previously reported (search for test_bug607584.xul) in bug 591726, bug 611238, bug 612448, and bug 612484.

The error on tinderbox (causing orange) looks like this (with variation in which test it's happening in):

7089 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/extensions/universalchardet/tests/test_bug171813.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - Components is not defined at chrome://mochitests/content/chrome/editor/libeditor/html/tests/test_bug607584.xul:57
7090 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/extensions/universalchardet/tests/test_bug171813.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - Components is not defined at chrome://mochitests/content/chrome/editor/libeditor/html/tests/test_bug607584.xul:57
Summary: test_bug607584.xul continues executing after we've left the page → intermittent orange: test_bug607584.xul continues executing after we've left the page
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1289916569.1289917592.13029.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test mochitest-other on 2010/11/16 06:09:29 
s: talos-r3-leopard-033

6354 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/extensions/universalchardet/tests/test_bug171813.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - Components is not defined at chrome://mochitests/content/chrome/editor/libeditor/html/tests/test_bug607584.xul:57
6355 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/extensions/universalchardet/tests/test_bug171813.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - Components is not defined at chrome://mochitests/content/chrome/editor/libeditor/html/tests/test_bug607584.xul:57
Summary: intermittent orange: test_bug607584.xul continues executing after we've left the page → intermittent orange: test_bug607584.xul continues executing after we've left the page, mostly showing up in test_bug171813.html
I recommend getting rid of this test. test_bug607584.html is largely enough for the patch.
Attached patch Patch (v1) (obsolete) — — Splinter Review 
We should remove the progress listener when we're done.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #490977 - Flags: review?(roc)
     var progress = docShell.QueryInterface(Components.interfaces.nsIInterfaceRequestor).getInterface(Components.interfaces.nsIWebProgress);
-    var progressListener = new EditorContentListener(newEditorElement);
+    progressListener = new EditorContentListener(newEditorElement);

Shouldn't you have removed 'var' from 'progress' instead of 'progressListener'?
Attached patch Patch (v1) — — Splinter Review 
(In reply to comment #10)
>      var progress =
> docShell.QueryInterface(Components.interfaces.nsIInterfaceRequestor).getInterface(Components.interfaces.nsIWebProgress);
> -    var progressListener = new EditorContentListener(newEditorElement);
> +    progressListener = new EditorContentListener(newEditorElement);
> 
> Shouldn't you have removed 'var' from 'progress' instead of 'progressListener'?

Yes.  Specifically, I should have qrefreshed the correct patch!
Attachment #490977 - Attachment is obsolete: true
Attachment #491114 - Flags: review?(roc)
Attachment #490977 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/b433764562cc
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: